Closed Bug 2059851 Opened 2 months ago Closed 28 days ago

[a11y] HNT Customize panel back buttons lack accessible name

Categories

(Firefox :: New Tab Page, defect)

Firefox 155
Unspecified
Windows 11
defect

Tracking

()

RESOLVED FIXED
157 Branch
Accessibility Severity s2
Tracking Status
firefox155 --- disabled
firefox156 --- disabled
firefox157 --- fixed

People

(Reporter: A02291979, Assigned: rhamoui)

References

(Blocks 1 open bug)

Details

(Keywords: access, Whiteboard: [hnt][hnt-wattle])

Attachments

(2 files)

Impacted Section/Element

HNT ("Settings" dialog, "Firefox Themes", "Widgets", and "Topics" dialogs)

Steps to Reproduce

On HNT, open DevTools. Activate the "Customize" button in the bottom right corner of the page. In the resulting "Settings" dialog, activate the "See more themes", "Manage widgets", and "Manage topics" buttons. In the resulting dialogs, inspect the "Back" right arrow icon buttons.

Expected Behavior

name conveys button function.

Actual Behavior

name is undefined.

User Impact

The right arrow icon buttons have visual labels and functions of "Back" but this is not announced to screen reader users.

WCAG 2.2 References

Recommendations

Apply aria-label="Back" to the right arrow icon buttons.

Testing Environment

Windows 11

Assistive Technology Used

Any

Further Reference

Severity

2-Significant

The Bugbug bot thinks this bug is an accessibility bug, but please revert this change in case of error.

Keywords: access
Accessibility Severity: --- → s2
Component: General → Theme
Blocks: 2060957

This seems like it could potentially use moz-page-header but just adding the aria-label would definitely be the quicker fix. Page header uses "Go back" (so does about:addons)

Component: Theme → New Tab Page
Summary: [a11y] Button lacks accessible name → [a11y] HNT Customize panel back buttons lack accessible name
Whiteboard: [hnt][hnt-wattle]
Assignee: nobody → rhamoui
Pushed by rhamoui@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/aeb130f65fd8 https://hg.mozilla.org/integration/autoland/rev/f4a12ab02e31 Create accessible label for customize menu's subpanel back buttons. r=fluent-reviewers,Dre,bolsson
Status: NEW → RESOLVED
Closed: 28 days ago
Resolution: --- → FIXED
Target Milestone: --- → 157 Branch

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit BugBot documentation.

The patch landed in nightly and beta is affected.
:rhamoui, is this bug important enough to require an uplift?

For more information, please visit BugBot documentation.

Flags: needinfo?(rhamoui)
Flags: needinfo?(rhamoui)
QA Whiteboard: [qa-triage-done-c158/b157]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: