2059920 - nsIWindowsShellService::canPinToTaskbar should error when pinning will be blocked by a group policy.

Status: RESOLVED FIXED

(Firefox :: Shell Integration, defect, P3)

Description

[Nick Rishel [:nrishel]]

We won't be able to pin if blocked by a policy, and should report such. Similar to Bug 2059888 even if WinRT's TaskbarManager::IsPinningAllowed returns false due to group policy, we fall through to the COM implementation which returns true whenever the Taskband Pin COM class is available.

Comment 1

[Nick Rishel [:nrishel]]

Attachment: Bug 2059920 - Add check for Taskbar pinning being blocked by Group Policy. r=hsohaney

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b546313a4058
https://hg.mozilla.org/integration/autoland/rev/8cc395285b07
Add check for Taskbar pinning being blocked by Group Policy. r=hsohaney

Comment 3

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/8cc395285b07

Comment 4

[Mike Kaply [:mkaply]]

This happens on Firefox 153, right? If so, should be uplifted to the ESR.

Comment 5

[Nick Rishel [:nrishel]]

I don't think uplift is necessary here. Pinning will fail in accordance with group policy if we try it, this is just trying to handle it more elegantly for error handling. See this stack for associated uplifts.

Comment 6

[Mike Kaply [:mkaply]]

Yeah, that's a lot. Lets not :)