205997 - nsPrefService::ReadAndOwnSharedUserPrefFile should use nsIFile.equals

Status: RESOLVED INCOMPLETE

(Core Graveyard :: Profile: BackEnd, defect, P5)

Description

[timeless]

nsresult nsPrefService::ReadAndOwnSharedUserPrefFile(nsIFile *aFile)
{
  NS_ENSURE_ARG(aFile);
  if (mCurrentSharedFile == aFile)
    return NS_OK;
  NS_IF_RELEASE(mCurrentSharedFile);

nsIFile is of course not an atom, but presumably this code is designed to avoid
reopening the same pref file. If that's the case then it should call Equals()

Comment 1

[timeless]

Attachment: like this

Comment 2

[Benjamin Smedberg]

Comment on attachment 134990 [details] [diff] [review]
like this

If you're gonna do it, do it all the way... see
http://lxr.mozilla.org/mozilla/source/modules/libpref/src/nsPrefService.cpp#508
and #543

And is there any reason we're not using a comptr here?

--BDS

Comment 3

[Benjamin Smedberg]

This bug is filed in a bugzilla component related to pre-Firefox code which no longer exists. I believe it is no longer relevant and I am therefore closing it INCOMPLETE.

If you believe that this bug is still valid and needs to be fixed, please reopen it and move it to the Toolkit:Startup and Profile System product/component.