206008 - needs control on the number of unread messages in newsgroups

Status: RESOLVED WORKSFORME

(MailNews Core :: Localization, defect)

Description

[Tsahi Asher]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; he-IL; rv:1.3) Gecko/20030312
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; he-IL; rv:1.3) Gecko/20030312

in the mail/news reader, a localizer has no control over the position of the
number of unread messages and the brackets that surroud it next to a newsgroup
name, and as a result, in a RTL localization (hebrew, arabic etc.) the closing
bracket is at the left end instead of the right end.

we should have something like

%group% (%S)

to control the position of the group name and the number of unread messages.

Reproducible: Always

Steps to Reproduce:
1. aligning the interface to the right: add these lines to the file intl.css, in
the locale\en-US\global, in the en-US.jar file (the language pack file, in the
chrome folder):

window,dialog,wizard,page {
  direction: rtl;
}

menu { direction: rtl; }

outliner { direction: rtl; }


2.open Mail and Newsgroups
3.register to a Usenet server, such as news.mozilla.org
4.register to a newsgroup on that server
5.look at the list of group(s) under the usenet account in the accounts pane
(should be on the right side after step 1).


Actual Results:  
i get the following:

(n.p.m.l10n(256

Expected Results:  

n.p.m.l10n(256)

this behaviour is correct according to the BiDi algorithm, but should be
overridden somehow.

Comment 1

[Tsahi Asher]

Attachment: screen shot

Comment 2

[Simon Montagu :smontagu]

-> mailnews l10n

Comment 3

[Tsahi Asher]

actually it's not just news groups, but pop/imap accounts too, where you see the
number of unread messages next to the accunt name.

Comment 4

[Simon Montagu :smontagu]

Currently the string is created by
nsMsgFolderDataSource::CreateUnreadMessagesNameString() at
http://lxr.mozilla.org/seamonkey/source/mailnews/base/src/nsMsgFolderDataSource.cpp#1125

AFAIK there's no reason why the code couldn't be changed to use a localizable
format string, but you would still need some subtle use of Unicode control
characters to solve the problem.

Comment 5

[Tsahi Asher]

i'll handle it :) just put it in the language pack somewhere.

Comment 6

[Simon Montagu :smontagu]

Attachment: Localizable format string

Comment 7

[Simon Montagu :smontagu]

Comment on attachment 123931 [details] [diff] [review]
Localizable format string

sspitzer, can you review?

Comment 8

[(not reading, please use [e-mail] instead)]

Comment on attachment 123931 [details] [diff] [review]
Localizable format string

simon, thanks for working on this.

but if we are going to fix this, we should go all the way.

why not:

folderNameWithUnreadCount=%1$S (%2$S)

that avoids the leading space thing, which can't be localized, right?

Comment 9

[(not reading, please use [e-mail] instead)]

also, you'll need l10n approval for this, ping robinf/bobj for that (unless you
have it already)

Comment 10

[Tsahi Asher]

i agree with seth. i'm not sure something like "(%S)" will be enough to control
the posistion of the brackets.

Comment 11

[Tsahi Asher]

what's up with this bug?

Comment 12

[Rob Lemley [:rjl]]

This appears to be correct now (at least for "he").