Closed
Bug 206008
Opened 21 years ago
Closed 1 year ago
needs control on the number of unread messages in newsgroups
Categories
(MailNews Core :: Localization, defect)
MailNews Core
Localization
Tracking
(Not tracked)
RESOLVED
WORKSFORME
People
(Reporter: tsahi_75, Unassigned)
Details
Attachments
(2 files)
20.27 KB,
image/gif
|
Details | |
2.57 KB,
patch
|
sspitzer
:
review-
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; he-IL; rv:1.3) Gecko/20030312 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; he-IL; rv:1.3) Gecko/20030312 in the mail/news reader, a localizer has no control over the position of the number of unread messages and the brackets that surroud it next to a newsgroup name, and as a result, in a RTL localization (hebrew, arabic etc.) the closing bracket is at the left end instead of the right end. we should have something like %group% (%S) to control the position of the group name and the number of unread messages. Reproducible: Always Steps to Reproduce: 1. aligning the interface to the right: add these lines to the file intl.css, in the locale\en-US\global, in the en-US.jar file (the language pack file, in the chrome folder): window,dialog,wizard,page { direction: rtl; } menu { direction: rtl; } outliner { direction: rtl; } 2.open Mail and Newsgroups 3.register to a Usenet server, such as news.mozilla.org 4.register to a newsgroup on that server 5.look at the list of group(s) under the usenet account in the accounts pane (should be on the right side after step 1). Actual Results: i get the following: (n.p.m.l10n(256 Expected Results: n.p.m.l10n(256) this behaviour is correct according to the BiDi algorithm, but should be overridden somehow.
Reporter | ||
Comment 1•21 years ago
|
||
Comment 2•21 years ago
|
||
-> mailnews l10n
Assignee: mkaply → rchen
Status: UNCONFIRMED → NEW
Component: BiDi Hebrew & Arabic → Localization
Ever confirmed: true
Product: Browser → MailNews
QA Contact: zach → marina
Summary: [RFE] needs control on the number of unread messages in newsgroups → [RFE] needs control on the number of unread messages in newsgroups
Reporter | ||
Comment 3•21 years ago
|
||
actually it's not just news groups, but pop/imap accounts too, where you see the number of unread messages next to the accunt name.
Comment 4•21 years ago
|
||
Currently the string is created by nsMsgFolderDataSource::CreateUnreadMessagesNameString() at http://lxr.mozilla.org/seamonkey/source/mailnews/base/src/nsMsgFolderDataSource.cpp#1125 AFAIK there's no reason why the code couldn't be changed to use a localizable format string, but you would still need some subtle use of Unicode control characters to solve the problem.
Reporter | ||
Comment 5•21 years ago
|
||
i'll handle it :) just put it in the language pack somewhere.
Comment 6•21 years ago
|
||
Comment 7•21 years ago
|
||
Comment on attachment 123931 [details] [diff] [review] Localizable format string sspitzer, can you review?
Attachment #123931 -
Flags: superreview?(sspitzer)
Attachment #123931 -
Flags: review?(sspitzer)
Comment 8•21 years ago
|
||
Comment on attachment 123931 [details] [diff] [review] Localizable format string simon, thanks for working on this. but if we are going to fix this, we should go all the way. why not: folderNameWithUnreadCount=%1$S (%2$S) that avoids the leading space thing, which can't be localized, right?
Attachment #123931 -
Flags: superreview?(sspitzer)
Attachment #123931 -
Flags: review?(sspitzer)
Attachment #123931 -
Flags: review-
Comment 9•21 years ago
|
||
also, you'll need l10n approval for this, ping robinf/bobj for that (unless you have it already)
Reporter | ||
Comment 10•21 years ago
|
||
i agree with seth. i'm not sure something like "(%S)" will be enough to control the posistion of the brackets.
Reporter | ||
Comment 11•21 years ago
|
||
what's up with this bug?
Reporter | ||
Updated•21 years ago
|
Summary: [RFE] needs control on the number of unread messages in newsgroups → needs control on the number of unread messages in newsgroups
Updated•20 years ago
|
Product: MailNews → Core
Updated•16 years ago
|
Assignee: rchen → nobody
OS: Windows XP → All
QA Contact: marina → localization
Hardware: PC → All
Assignee | ||
Updated•16 years ago
|
Product: Core → MailNews Core
Updated•2 years ago
|
Severity: normal → S3
Comment 12•1 year ago
|
||
This appears to be correct now (at least for "he").
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•