Closed
Bug 206111
Opened 21 years ago
Closed 21 years ago
more MinGW Thunderbird gcc build bustage
Categories
(SeaMonkey :: MailNews: Message Display, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dmosedale, Assigned: dmosedale)
References
Details
Attachments
(1 file, 1 obsolete file)
534 bytes,
patch
|
Details | Diff | Splinter Review |
This is similar to the mailnews/import/build bustage, where a library was showing up too late in the link line and failing to resolve symbols as a result. Patch coming up...
Assignee | ||
Comment 1•21 years ago
|
||
I kind of suspect we could also get rid of this line: $(PROGRAM): $(DIST)/lib/$(LIB_PREFIX)xulapp_s.$(LIB_SUFFIX) in the patch. cls, is that correct?
No idea since the patch doesn't contain that line and I don't build thunderbird. The fact that all of those libs are being added to EXTRA_LIBS is suspect to begin with though.
Assignee | ||
Comment 3•21 years ago
|
||
OK, this should be. I think I was wrong about being able to remove the dependency in my last comment. Additionally, this fixes the problem that cls pointed out, which is that EXTRA_LIBS is for OS-level libraries, not Mozilla stuff. So this version moves everything to LIBS.
Attachment #123611 -
Attachment is obsolete: true
Comment 4•21 years ago
|
||
fix checked in. Thanks for the patch Dan.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Comment 5•21 years ago
|
||
Dan, this compiled for me in a debug build but it broke optimized bits. $(call EXPAND_LIBNAME, xulapp_s) caused a build error saying xulapp_s not defined when I tried to make an optimized build this morning. I had to go back to the way it was before to compile.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 6•21 years ago
|
||
Since Scott only did a partial backout, the code in the tree still works nicely with MinGW gcc. So this bug can be closed.
Status: REOPENED → RESOLVED
Closed: 21 years ago → 21 years ago
Resolution: --- → FIXED
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•