206111 - more MinGW Thunderbird gcc build bustage

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Dan Mosedale (:dmosedale, :dmose)]

This is similar to the mailnews/import/build bustage, where a library was
showing up too late in the link line and failing to resolve symbols as a result.
 Patch coming up...

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: patch v1

I kind of suspect we could also get rid of this line:

$(PROGRAM): $(DIST)/lib/$(LIB_PREFIX)xulapp_s.$(LIB_SUFFIX)

in the patch. cls, is that correct?

Comment 2

[cls]

No idea since the patch doesn't contain that line and I don't build thunderbird.
 The fact that all of those libs are being added to EXTRA_LIBS is suspect to
begin with though.

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: patch, v2

OK, this should be.  I think I was wrong about being able to remove the
dependency in my last comment.	Additionally, this fixes the problem that cls
pointed out, which is that EXTRA_LIBS is for OS-level libraries, not Mozilla
stuff.	So this version moves everything to LIBS.

Comment 4

[Scott MacGregor]

fix checked in. Thanks for the patch Dan.

Comment 5

[Scott MacGregor]

Dan, this compiled for me in a debug build but it broke optimized bits. 

$(call EXPAND_LIBNAME, xulapp_s)

caused a build error saying xulapp_s not defined when I tried to make an
optimized build this morning. I had to go back to the way it was before to compile.

Comment 6

[Dan Mosedale (:dmosedale, :dmose)]

Since Scott only did a partial backout, the code in the tree still works nicely
with MinGW gcc.  So this bug can be closed.