Closed
Bug 206143
Opened 21 years ago
Closed 21 years ago
netwerk/cache/src/Makefile.in should not use EXPORT_LIBRARY
Categories
(Core :: Networking: Cache, defect)
Core
Networking: Cache
Tracking
()
RESOLVED
FIXED
People
(Reporter: bryner, Assigned: bryner)
Details
Attachments
(1 file)
|
471 bytes,
patch
|
darin.moz
:
review+
alecf
:
superreview+
mkaply
:
approval1.4+
|
Details | Diff | Splinter Review |
I ran across this while debugging some other stuff.. this looks like cruft from when cache was its own module. Setting EXPORT_LIBRARY=1 is causing the cache static lib to get linked in again when building a static binary, which is unnecessary since it's merged into libnecko.
|
Assignee | |
Comment 1•21 years ago
|
||
|
|
Assignee | |
Updated•21 years ago
|
Attachment #123626 -
Flags: superreview?(alecf)
Attachment #123626 -
Flags: review?(darin)
|
||
Comment 2•21 years ago
|
||
Comment on attachment 123626 [details] [diff] [review] remove cruft sr=alecf
Attachment #123626 -
Flags: superreview?(alecf) → superreview+
|
||
Comment 3•21 years ago
|
||
Comment on attachment 123626 [details] [diff] [review] remove cruft r=darin
Attachment #123626 -
Flags: review?(darin) → review+
|
|
Assignee | |
Comment 4•21 years ago
|
||
Comment on attachment 123626 [details] [diff] [review] remove cruft Can I get this in for 1.4? It's a trivial change and should only affect static builds.
Attachment #123626 -
Flags: approval1.4?
|
||
Comment 5•21 years ago
|
||
Comment on attachment 123626 [details] [diff] [review] remove cruft a=mkaply for 1.4
Attachment #123626 -
Flags: approval1.4? → approval1.4+
|
|
Assignee | |
Comment 6•21 years ago
|
||
checked in.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•