206339 - improve PR_LOGGING for junk mail filter, so we can evaluate problems

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[(not reading, please use [e-mail] instead)]

add PR_LOG for junk mail filter, so we can evaluate problems

there are a couple bugs that it would really help to have some verbose pr
logging of the junk mail filter in order to track down issues.

Comment 1

[(not reading, please use [e-mail] instead)]

adding two bugs which this would really be helpful

Comment 2

[(not reading, please use [e-mail] instead)]

blocking 1.4.

this shouldn't add risk (since it will be off by default), but gives us a way to
track down problems in 1.4 final bits.

Comment 3

[(not reading, please use [e-mail] instead)]

Attachment: [checked in] patch

this is really verbose.  but it's a start.

Comment 4

[(not reading, please use [e-mail] instead)]

ok, that patch has landed.  r/sr=bienvenu, a=sspitzer

now, this can morph to improving the logging.  we need log levels, so that we
can reduce the verboseness.

there's also some more things I'd like to PR_LOG.

no longer blocks 1.4

Comment 5

[(not reading, please use [e-mail] instead)]

to use this, on windows:

NSPR_LOG_FILE=c:\log.txt
NSPR_LOG_MODULES=BayesianFilter:5

watch out, log.txt is going to get big on you.

mine got to be 41 MB!  (this is why the bug is still open, it's too verbose)

Comment 6

[earthsound]

Would bug 181534 sidestep the intention of this bug (evaluating the problems of 
the current junk filter implementation), or does this bug block 181534?

Comment 7

[(not reading, please use [e-mail] instead)]

sorry for the spam.  making bugzilla reflect reality as I'm not working on these bugs.  filter on FOOBARCHEESE to remove these in bulk.

Comment 8

[Kent James (:rkent)]

Attachment: Add rational log levels

The existing spam logging, as mentioned in comment 5, always generates large amounts of output. This patch provides 4 different amounts of logging output:

+// Logging levels are implemented as follows:
+//   1 (PR_LOG_ALWAYS) just show one line per message with junk score
+//   2 (PR_LOG_ERROR) add any error messages
+//   3 (PR_LOG_WARNING) add per message tokens used
+//   4 (PR_LOG_DEBUG) add additional tokenization results plus other details

This should satisfy the needs and allow closing of this bug (plus of course allowing logging to be enabled more routinely by people who want to track spam performance without all of the excessive output).

Comment 9

[Magnus Melin [:mkmelin]]

Comment on attachment 295742 [details] [diff] [review]
Add rational log levels

I'm only a reviewer for mail/ - looks good to me though. 

Try r?/sr? from bienvenu, he's ccd.

Comment 10

[David :Bienvenu]

Comment on attachment 295742 [details] [diff] [review]
Add rational log levels

thx, Kent.

Comment 11

[Reed Loden [:reed]]

Checking in mailnews/extensions/bayesian-spam-filter/src/nsBayesianFilter.cpp;
/cvsroot/mozilla/mailnews/extensions/bayesian-spam-filter/src/nsBayesianFilter.cpp,v  <--  nsBayesianFilter.cpp
new revision: 1.68; previous revision: 1.67
done