Closed Bug 2064596 Opened 2 months ago Closed 2 months ago

[text-box-trim] Trim on inline boxes removes border and padding

Categories

(Core :: Layout: Block and Inline, defect)

defect

Tracking

()

RESOLVED FIXED
156 Branch
Tracking Status
firefox154 --- wontfix
firefox155 --- wontfix
firefox156 --- fixed

People

(Reporter: sajidanwar, Assigned: sajidanwar)

References

(Blocks 1 open bug)

Details

Attachments

(1 external file)

text-box-trim can be specified on inline boxes, and the expected effect is that the content box edge is trimmed to match the selected text-box-edge. The border and padding should be unaffected.

The implementation in Firefox right now is incorrectly treating the border and padding as part of the content box bounds and is trimming that down, which completely disappears the padding and causes the border to grow "inward". See: https://codepen.io/kbhomes/pen/QwdvWXG

Assignee: nobody → sajidanwar94
Status: NEW → ASSIGNED
Pushed by sajidanwar94@gmail.com: https://github.com/mozilla-firefox/firefox/commit/f60720040c58 https://hg.mozilla.org/integration/autoland/rev/a756f9aef18b Exclude border/padding when applying text-box-trim to inline boxes. r=layout-reviewers,dshin
Pushed by sstanca@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/8f2a496a039d https://hg.mozilla.org/integration/autoland/rev/3e707bdf2c67 Revert "Bug 2064596 - Exclude border/padding when applying text-box-trim to inline boxes. r=layout-reviewers,dshin" for causing wpt failures in text-box-trim-inline-box-005.html.

Reverted this because it was causing wpt failures in text-box-trim-inline-box-005.html.

Flags: needinfo?(sajidanwar94)
Pushed by sajidanwar94@gmail.com: https://github.com/mozilla-firefox/firefox/commit/bec057ba804e https://hg.mozilla.org/integration/autoland/rev/8ab970302b57 Exclude border/padding when applying text-box-trim to inline boxes. r=layout-reviewers,dshin
Pushed by rperta@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/52dab2f70d34 https://hg.mozilla.org/integration/autoland/rev/d7cf11611536 Revert "Bug 2064596 - Exclude border/padding when applying text-box-trim to inline boxes. r=layout-reviewers,dshin" for causing wr failures at text-box-trim-inline-box-005.html

Backed out for causing wr failures at text-box-trim-inline-box-005.html
Backout link
Push with failures
Failure log(s)

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/62080 for changes under testing/web-platform/tests

Upstream PR was closed without merging

Pushed by sajidanwar94@gmail.com: https://github.com/mozilla-firefox/firefox/commit/38e7600e47da https://hg.mozilla.org/integration/autoland/rev/30683496c930 Exclude border/padding when applying text-box-trim to inline boxes. r=layout-reviewers,dshin
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 156 Branch
Flags: needinfo?(sajidanwar94)

Upstream PR merged by moz-wptsync-bot

QA Whiteboard: [qa-triage-done-c157/b156]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: