206504 - Views dropdown menu quickly loses focus/highlight

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Ninoschka Baca]

Trunk build 2003-05-20: WinMe, Mac 10.1.5, Linux RH 8

Overview: Move the cursor over the Veiws dropdown menu items and notice that it
highlights an entry and quickly unhighlights. Because of this it is difficult to
choose the Customize option. 

Steps to reproduce:
1. Click on the Views dropdown
2. Move the cursor to any item in the drop down list 
3. Now try to move the cursor to the Customize option at the bottom

Actual Results: The Views dropdown menu closes before I havea chance to select
Customize to open the Customize Message Views dialog.

Expected Results: When the cursor lands on a views dropdown item, it should
remain higlighted until the cursor moves.

Comment 1

[Ninoschka Baca]

Marking nsbeta1 because this was working as of build 2003-05-06. It's also
confusing/frustrating for the Views dropdown to lose focus or to close when
trying to select the Customize item. It should be fixed for this release.

Comment 2

[Ninoschka Baca]

Sarah, have you seen this problem in any of the browser windows?

Comment 3

[sairuh (rarely reading bugmail)]

hm, out of curiosity i tried reproducing this by using the down arrow key (after
clicking to expand View dropdown menu with mouse). i got into a state where
focus was gone (couldn't move the highlight), and the app crashed. occurred on
both my linux box and Ninoschka's OS X machine.

no talkback appeared, so am going to see if i can get a crash report.

Comment 4

[sairuh (rarely reading bugmail)]

nbaca mentioned that this wasn't a problem with 5/6 builds. will get regression
window in a moment.

i'm not sure if the crash i saw is related. if it isn't, feel free to remove the
crash kw, and i'll spin off another bug. here's the top of the trace:

Thread 0 Crashed:
 #0   0x001d6efc in nsCOMPtr_base::begin_assignment()
 #1   0x012c2b08 in nsXULElement::GetAttr(int, nsIAtom*, nsAString&) const
 #2   0x010b0710 in nsMenuFrame::IsDisabled()
 #3   0x01351ad0 in nsMenuFrame::MenuIsDisabled(int&)
 #4   0x010aaee4 in nsMenuPopupFrame::KeyboardNavigation(unsigned, int&)
 #5   0x010b0334 in nsMenuFrame::KeyboardNavigation(unsigned, int&)

Comment 5

[sairuh (rarely reading bugmail)]

Attachment: crash report on OS X 10.2.6, build 2003.05.20.08

Comment 6

[sairuh (rarely reading bugmail)]

works fine with 2003.05.07.03, broken in 2003.05.08.08.

Comment 7

[sairuh (rarely reading bugmail)]

i've checked a couple of dropmenus in the preferences dialog (eg, Fonts,
Navigator and Languages), and i couldn't repro the problems that nbaca and i
saw. nor can i repro with the dropmenus in the JMC dlg. perhaps it's specific
only to View in the mailnews 3pane...

Comment 8

[sairuh (rarely reading bugmail)]

5 hour window, this broke btwn the 3am and 8am builds on 5/8.

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=05%2F08%2F2003+03%3A00&maxdate=05%2F08%2F2003+08%3A00&cvsroot=%2Fcvsroot

Comment 9

[sairuh (rarely reading bugmail)]

got talkback to appear on win2k. report is at
http://climate.netscape.com/reports/SingleIncidentInfo.cfm?dynamicBBID=20286200

Comment 10

[(not reading, please use [e-mail] instead)]

I got the crash, too, (same recursive stack) when using the keyboard (not the
mouse).

I'll go look through the checkins.

Comment 11

[(not reading, please use [e-mail] instead)]

working on this for 1.4 final

Comment 12

[(not reading, please use [e-mail] instead)]

so, my apologies to sarah and bryner.

I was so sure this wasn't me, that I dragged bryner into it.

and 5 minutes later, he tells me it was me.

my only defense (which is paper thin) is that couldn't reproduce this on my
debug build at home, but I could at work.

but that's not excuse.

here's the fix:

Index: resources/content/msgViewPickerOverlay.js
===================================================================
RCS file: /cvsroot/mozilla/mailnews/extensions/mailviews/resources/content/msgVi
ewPickerOverlay.js,v
retrieving revision 1.7
diff -r1.7 msgViewPickerOverlay.js
221c221
<   viewPicker.selectedItem = document.getElementsByAttribute("value", aValue)[0
];
---
>   viewPicker.selectedItem = viewPicker.getElementsByAttribute("value", aValue)
[0];

Comment 13

[(not reading, please use [e-mail] instead)]

fixed.  also thanks to nbaca and sarah for finding and tracking this one down.

Comment 14

[Greg K.]

Is this related to bug 206315 at all?

Comment 15

[sairuh (rarely reading bugmail)]

*** Bug 206315 has been marked as a duplicate of this bug. ***

Comment 16

[[e-mail]]

Seth wrote:

> here's the fix:

viewPicker.selectedItem = viewPicker.getElementsByAttribute("value", aValue)[0];

Actually, you should have used all along:

viewPicker.value = aValue;

Comment 17

[(not reading, please use [e-mail] instead)]

thanks neil.  I'll try that in my tree, and it will land in 1.5.

Comment 18

[Ninoschka Baca]

Trunk build 2003-05-22: WinMe, Mac 10.1.5, Linux RH 8
Verified Fixed. Using the mouse or the arrow keys work as expected (focus
remains on the View dropdown item based on cursor location) and without a crash.