206556 - Profile manager should not mention stored mail messages, bookmarks or other application-specific items

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[Alexander Nguyen]

User-Agent:       Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.4b) Gecko/20030516 Mozilla Firebird/0.6
Build Identifier: Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.4b) Gecko/20030516 Mozilla Firebird/0.6

Since Firebird is only a browser, the profile manager should not mention that a
Firebird profile stores e-mail messages.

Reproducible: Always

Steps to Reproduce:
1. Start Mozilla Firebird with the Profile Manager. Read the accompanying text.

Comment 1

[Erik]

Confirming using Mozilla/5.0 (Windows; U; WinNT4.0; en-US; rv:1.4b)
Gecko/20030601 Mozilla Firebird/0.6

There are 5 references to mail / messages related to profile dialogs:

- in {Select USer profile}
- in {Manage User Profiles}
- in {Delete Profile}
- in the 2 dialogs of the profile creation wizard labeled {Create Profile}

Comment 2

[Simon Paquet [:sipaq]]

Attachment: patch v1

Easy patch, which removes application-specific wording from the profile
dialogs. This should also go on the branch, when it has been reviewed, since we
probably need that for XULRunner's first release as well.

Comment 3

[Asaf Romano (gone)]

Comment on attachment 194813 [details] [diff] [review]
patch v1

moving request to bsmedberg.

Comment 4

[Benjamin Smedberg]

Comment on attachment 194813 [details] [diff] [review]
patch v1

Actually, you're breaking my rule about l10n keys here: when you substantively
change the text, you should rename the key, so that localizers end up with an
orange tbox and know that they're supposed to re-translate the key.

Comment 5

[Piotr Komoda]

Any chances to get this on branch? We (AviaryPL) would really love to see this
in 1.5's.

Comment 6

[Simon Paquet [:sipaq]]

Attachment: patch v2

This patch addresses the review comments from Benjamin.

Comment 7

[Piotr Komoda]

Didn't get on 1.5b2, so maybe there's a chance for 1.5 RC1?

Comment 8

[Simon Paquet [:sipaq]]

Comment on attachment 198227 [details] [diff] [review]
patch v2

Asking for approval. Low-risk wording-only patch with l10n-impact.

Comment 9

[Asa Dotzler [:asa]]

Comment on attachment 198227 [details] [diff] [review]
patch v2

too late for string changes.

Comment 10

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in toolkit/locales/en-US/chrome/mozapps/profile/createProfileWizard.dtd;
/cvsroot/mozilla/toolkit/locales/en-US/chrome/mozapps/profile/createProfileWizard.dtd,v
 <--  createProfileWizard.dtd
new revision: 1.3; previous revision: 1.2
done
Checking in
toolkit/locales/en-US/chrome/mozapps/profile/profileSelection.properties;
/cvsroot/mozilla/toolkit/locales/en-US/chrome/mozapps/profile/profileSelection.properties,v
 <--  profileSelection.propertiesnew revision: 1.5; previous revision: 1.4
done
Checking in toolkit/profile/content/createProfileWizard.xul;
/cvsroot/mozilla/toolkit/profile/content/createProfileWizard.xul,v  <-- 
createProfileWizard.xul
new revision: 1.4; previous revision: 1.3
done
Checking in toolkit/profile/content/profileSelection.js;
/cvsroot/mozilla/toolkit/profile/content/profileSelection.js,v  <-- 
profileSelection.js
new revision: 1.10; previous revision: 1.9
done