206595 - Unblocking Images from a Server does not change the text in the context menu

Status: VERIFIED FIXED

(Firefox :: Menus, defect)

Description

[Albert R.]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4b) Gecko/20030516 Mozilla Firebird/0.6
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4b) Gecko/20030516 Mozilla Firebird/0.6

After blocking an image, the text in the context menu changes from "Block images
from this server" to "Unblock images from this server" or there is an
affirmative checkbox, in the case of MozFB.  However, if I attempt to unblock
images from the server using the context menu, the server is successfully
unblocked (eg images work again) but the context menu text remains at "Unblock"
or with the checkmark.  

Reproducible: Always

Steps to Reproduce:
1. Block image from server using context menu (e.g. doubleclick.net or some
other advertising conglomerate)
2. Reload page, images are blocked
3. Unblock image from server using context menu
4. Reload page, right click on an image again and look at the context menu
Actual Results:  
Images are successfully unblocked but the "unblock" text remains

Expected Results:  
"Unblock" text should have changed over to "block"

Comment 1

[Albert R.]

Ack, just noticed it works as expected in the latest trunk build (2003052004),
but not the latest MozFB build.  I accidentally tested against an old trunk
build and didn't notice that it was old.  Can someone change this to a Phoenix
bug?  I suppose it fits under the category of Menus.

I also discovered that a work around was to go into the Image permissions and
remove the entry for the server altogether.

Comment 2

[Simon Paquet [:sipaq]]

Confirming on Mozilla Firebird/0.6 (Windows 2000; Gecko/20030521)

Comment 3

[Nate]

I've found this bug as well. It seems like "Block images from this server" does
not appear to work at all for MozillaFB.

Comment 4

[Iren]

Confirming on Mozilla/5.0 (Windows; U; WinNT4.0; en-US; rv:1.4b) Gecko/20030616
Mozilla Firebird/0.6

1. some earlier versions didn't have this bug

2. here's an addition: after you block the images from a server with the help of
context menu, they disappear; after unblocking they show up but the checkbox
remains as if they were blocked. THEN if again you try to block them, it doesn't
work anymore! no matter how many times you try, the checkbox remains and they
are shown. the status of the site in Options/Web Features/Image manager always
remains "site can load images". the only way to block them again is to remove
the site from the list in Options/Web Features/Image manager and block them with
the help of context menu.

Comment 5

[Simon Paquet [:sipaq]]

*** Bug 212704 has been marked as a duplicate of this bug. ***

Comment 6

[Nitin (vfwlkr)]

Should this be reassigned to the Firebird/Menus module owner instead of the
Browser/Image Blocking owner?

Comment 7

[Albert R.]

Duly noted :)

Comment 8

[Simon Paquet [:sipaq]]

Taking QA Contact as designated owner of Firebird-Menus. Sorry for bugspam.

Comment 9

[eric lindvall]

Attachment: a patch to fix the block/unblock problem.

This fixes the problem with the block/unblock problem in the context menu.

Comment 10

[eric lindvall]

Comment on attachment 129345 [details] [diff] [review]
a patch to fix the block/unblock problem.

please review.

Comment 11

[David Hyatt]

Fixed.

Comment 12

[Pham]

*** Bug 216066 has been marked as a duplicate of this bug. ***

Comment 13

[Nitin (vfwlkr)]

Someone with permissions please reopen

Does not work for me with:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5b) Gecko/20030815 Mozilla
Firebird/0.6.1+

URL: 
http://forums.mozillazine.org/viewtopic.php?t=20217

Steps:
1. Right click on the image of first poster.
2. select: block images from forums.mozillazine.org
3. refresh page
4. Right click below the name of the first poster
5. select: block images from forums.mozillazine.org (Already has a tickmark)
6. refresh page
7. The images reload
8. Now try to reblock: right click on image of first poster
9. block images from forums.mozillazine.org still has a checkmark.

Go to tools->options->load images->permissions
forums.mozillazine.org is listed as "site can load images"

Comment 14

[Nitin (vfwlkr)]

Attachment: Screenshot of bug

Adding a screenshot with latest build

Comment 15

[WD]

WFM Firebird 20030816 Win2k

Comment 16

[Dai Toyama]

WFM.

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5b) Gecko/20030815 Mozilla
Firebird/0.6.1+

Comment 17

[Nitin (vfwlkr)]

Hmmn, Upgraded to official 2003-08-16 build (from my 2003-08-15 CVS build), and
it works fine... must recheck my build config. 

Marked screenshot as obsolete.

Comment 18

[Mike Connor [:mconnor]]

Verified using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5b)
Gecko/20030817 Mozilla Firebird/0.6.1+