2066474 - Lists widget switcher menu no longer shows a checkmark on the selected list

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect)

Description

[Irene Ni [:ini]]

Attachment: Screenshot 2026-08-25 at 11.02.40 AM.png

STR

1. Set browser.newtabpage.activity-stream.widgets.system.lists.enabled to true
2. From the widget context menu, create a new list
3. Click on the drop-down arrow next to the list title
   Expected: there should be a checkmark next to the currently selected list

Issue: no checkmark is visible

The switcher passes checked before type="checkbox", and React assigns custom element props in source order, so panel-item's checked setter runs while type is still unset and no-ops — the checked attribute is never written, so nothing matches :host([type="checkbox"][checked]). Every other checkbox panel-item in newtab orders type first, which is why the Stocks list dropdown still checks.

Comment 1

[Irene Ni [:ini]]

Attachment: Bug 2066474 - Restore selected checkmark on lists widget switcher menu. r=#home-newtab-wattle-reviewers-rotation

Comment 2

[BugBot [:suhaib / :marco]]

The severity field is not set for this bug.
:thecount, could you have a look please?

For more information, please visit BugBot documentation.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/794c470b6782
https://hg.mozilla.org/integration/autoland/rev/867a65255cbe
Restore selected checkmark on lists widget switcher menu. r=maxx

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3998bffd3c55
https://hg.mozilla.org/integration/autoland/rev/d8e37e76dddb
Revert "Bug 2066474 - Restore selected checkmark on lists widget switcher menu. r=maxx" for causing node failures

Comment 5

[Silaghi Andreea]

Backed out for causing node failures
Backout Link
Push with failures
Failure Log
Failure line TEST-UNEXPECTED-FAIL | karma /builds/worker/checkouts/gecko/browser/extensions/newtab | activity-stream:<Lists> marks only the selected list as checked in the switcher: expected undefined to equal false

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7494a82306da
https://hg.mozilla.org/integration/autoland/rev/843155ca8ee9
Restore selected checkmark on lists widget switcher menu. r=maxx

Comment 7

[amarc]

https://hg.mozilla.org/mozilla-central/rev/843155ca8ee9