2066562 - Support Multiple Custom Wallpapers: Allow deleting a saved custom wallpaper

Status: RESOLVED FIXED

(Firefox :: New Tab Page, task)

Description

[dgrant]

Adds a way to remove a saved wallpaper.

Comment 1

[dgrant]

Attachment: Bug 2066562 - Multi-Custom Wallpapers: Allow deleting a saved custom wallpaper r?#home-newtab-reviewers

The "Your images" folder has no way to remove anything, so a saved wallpaper is kept forever once it is added.

This patch gives each saved image its own remove button, revealed on hover or keyboard focus the same way the Stocks watchlist does it, plus a confirmation before anything goes. Removing takes the image, its thumbnail and its details file together. Removing the one currently applied also drops the copy in the wallpaper folder and clears the selection, so the page falls back rather than pointing at a file that is gone.

Numbers are never reused. Removing image 2 leaves image 3 called image 3. The next image added is 5 rather than filling the gap, so what a screen reader reads for a picture does not change under someone.

Off by default behind newtabWallpapers.customWallpaper.library.enabled, along with the folder itself.

Comment 2

[Ayshath Nasreena]

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/178590548f0d
https://hg.mozilla.org/integration/autoland/rev/59b1349c3da2
Multi-Custom Wallpapers: Allow deleting a saved custom wallpaper r=mconley

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/59b1349c3da2