Closed Bug 2067229 Opened 2 months ago Closed 2 months ago

alarms.clearAll should return undefined instead of a boolean

Categories

(WebExtensions :: General, task, P3)

task

Tracking

(firefox157 fixed)

RESOLVED FIXED
157 Branch
Tracking Status
firefox157 --- fixed

People

(Reporter: robwu, Assigned: ollie, Mentored)

References

Details

(Keywords: dev-doc-complete, good-first-bug, Whiteboard: [wecg], [wptsync upstream])

Attachments

(1 external file)

In the WECG we just reached consensus that the alarms.clearAll method should return undefined (or more precisely: a Promise resolving to undefined), instead of the current boolean true/false.

Implementing that is fairly simple:

Interestingly, the current tests only assert that the return value is true, never the case for false. That already shows that the decision in the WECG is the right one - we did not even have test coverage for the false value.

dev-doc-needed: once the fix has landed we should document the new behavior on MDN.

Severity: -- → N/A
Priority: -- → P3

I'd like to work on this if no one else is looking into it :)

Assignee: nobody → ohensmancrook
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 157 Branch

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/62518 for changes under testing/web-platform/tests

Whiteboard: [wecg] → [wecg], [wptsync upstream]

Upstream PR merged by moz-wptsync-bot

Documentation requirements addressed in-

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: