Closed
Bug 206762
Opened 21 years ago
Closed 21 years ago
[AxPlugin] plugin confuses controls by ignoring their pleas to be resized
Categories
(Core Graveyard :: Embedding: APIs, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: adamlock, Assigned: adamlock)
References
Details
(Keywords: fixed1.4)
Attachments
(1 file)
730 bytes,
patch
|
dbradley
:
review+
alecf
:
superreview+
asa
:
approval1.4+
|
Details | Diff | Splinter Review |
The implementation of IOleInPlaceSite::OnPosRectChange in the plugin is wrong and confusing controls that try to be resized. The impl should call IOleInPlaceObject::SetObjectRects to notify the control of its permitted new size.
Patch calls IOleInPlaceObject::SetObjectRects from OnPosRectChange so the control knows its new size. This function forces controls to be the same size as specified by the container.
Comment on attachment 123981 [details] [diff] [review] Patch Can I have an r/sr on this simple patch please? It fixes controls that ask permission to be resized. Thanks
Attachment #123981 -
Flags: superreview?(alecf)
Attachment #123981 -
Flags: review?(dbradley)
Comment 3•21 years ago
|
||
Comment on attachment 123981 [details] [diff] [review] Patch sr=alecf
Attachment #123981 -
Flags: superreview?(alecf) → superreview+
Comment 4•21 years ago
|
||
Comment on attachment 123981 [details] [diff] [review] Patch r=dbradley
Attachment #123981 -
Flags: review?(dbradley) → review+
Comment on attachment 123981 [details] [diff] [review] Patch Fix checked into trunk. Seeking 1.4 checkin approval. Fix is obvious and restricted to the plugin.
Attachment #123981 -
Flags: approval1.4?
Comment 6•21 years ago
|
||
Comment on attachment 123981 [details] [diff] [review] Patch a=asa (on behalf of drivers) for checkin to the 1.4 branch.
Attachment #123981 -
Flags: approval1.4? → approval1.4+
Fix checked into 1.4 branch
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Updated•5 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•