206803 - Chatzilla and calendar window menu items shows up below the menu separator

Status: VERIFIED FIXED

(Other Applications :: ChatZilla, defect)

Description

[Sean Su]

depending on if chatzilla and/or calendar is installed, either chatzilla and/or
calendar menu item will show up below the menu seperator.

It looks like who ever is the last menu item will be shown below the menu seperator.

images of the problems coming up.

Comment 1

[Sean Su]

Attachment: image of problem

Comment 2

[Sean Su]

Attachment: image after fix

Comment 3

[Sean Su]

Attachment: patch v1.0

this patch seems to fix the problem, however, this has only been verified on
win32.	I'll try applying the patch on the other platforms to make sure they
still look okay.

Comment 4

[Chris Casciano]

updating typo in summary to make this findable... sorry for the spam

Comment 5

[Chris Casciano]

*** Bug 207345 has been marked as a duplicate of this bug. ***

Comment 6

[Chris Casciano]

this looks to have caused by bug 205865. (i see most of the people here are on
the bug already... just making the connection permanent... sorry for the spam)

Comment 7

[Jo Hermans]

*** Bug 207957 has been marked as a duplicate of this bug. ***

Comment 8

[Jo Hermans]

*** Bug 210770 has been marked as a duplicate of this bug. ***

Comment 9

[Jo Hermans]

*** Bug 211631 has been marked as a duplicate of this bug. ***

Comment 10

[Scott MacGregor]

chatzilla seems fixed, but calendar is not.

Comment 11

[Scott MacGregor]

*** Bug 227676 has been marked as a duplicate of this bug. ***

Comment 12

[Scott MacGregor]

chatzilla seems fixed to me.

Comment 13

[Scott MacGregor]

Attachment: patch

Comment 14

[Malcolm Rowe]

ChatZilla *isn't* fixed. I just installed 1.6b (Windows, custom install, no
MailNews or Spellcheck) and I get pretty much the same as attachment 124010 [details].

Comment 15

[Kai de Leeuw]

re comment 14, that depends on fact that the patch isn't checked in. ;)

Comment 16

[James Ross]

I'm pretty sure nothing's changed wrt Chatzilla, as CVS still have the same
insertafter="tasksMenuAddressBook" attribute it's always had. This is the
problem, it relies on Address Book being installed. Question is, what should it
use? Ordinal positioning is out, could we just list all the items that go above
it in bottom-to-top order?

Updating summary.

Comment 17

[Scott MacGregor]

> it relies on Address Book being installed

ah, that's why it appeared fixed to me.

Comment 18

[(not reading, please use [e-mail] instead)]

Comment on attachment 136955 [details] [diff] [review]
patch

sr/a=sspitzer for 1.6

Comment 19

[(not reading, please use [e-mail] instead)]

the calendar side is fixed.

but james brings up a good point, which still needs to be addressed.

Checking in calendarOverlay.xul;
/cvsroot/mozilla/calendar/resources/content/calendarOverlay.xul,v  <--  calendar
Overlay.xul
new revision: 1.14; previous revision: 1.13
done

Comment 20

[Prognathous]

(In reply to comment #16)
> it relies on Address Book being installed.

Not in my case. I have the Address Book installed, yet Chatzilla is still listed
after a separator:

  Navigator
  Mail & Newsgroups
  Composer
  Address Book
  -- separator --
  IRC Chat

Prog.

Comment 21

[James Ross]

(In reply to comment #20)
> (In reply to comment #16)
> > it relies on Address Book being installed.
> 
> Not in my case. I have the Address Book installed, yet Chatzilla is still listed
> after a separator:

See
http://lxr.mozilla.org/mozilla/source/extensions/irc/xul/content/chatzillaOverlay.xul#22
- if Calendar is still using that ID, and it's not appearing right after it, you
have a lovely XUL overlay bug on your hands. :)

Comment 22

[James Ross]

Sorry for he spam: I meant if Address Book still has that ID.

Comment 23

[[e-mail]]

Attachment: Implement comment 16

Tested on a --disable-mailnews build.

Comment 24

[James Ross]

Comment on attachment 170849 [details] [diff] [review]
Implement comment 16

>Index: chatzillaOverlay.xul
>+        insertafter="tasksMenuAddressBook,tasksMenuEditor,IMMenuItem,tasksMenuNavigator"/>

I thought there were 5 things above ChatZilla usually? Yeah, you missed out the
Mail&News item - is that missing for a reason?

Comment 25

[James Ross]

CCing Neil as I don't think he got my comment about the patch.

Neil, see comment 24.

Comment 26

[[e-mail]]

(In reply to comment #24)
>Yeah, you missed out the Mail&News item - is that missing for a reason?
The mailnews and addressbook items are not available separately.

Comment 27

[[e-mail]]

Fix checked in.

Comment 28

[Steve Chapel]

v