Purify UMR in PR_Poll's poll() call

RESOLVED FIXED in 4.4.1

Status

defect
RESOLVED FIXED
16 years ago
16 years ago

People

(Reporter: wtc, Assigned: wtc)

Tracking

4.4.1
Sun
Solaris

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Assignee

Description

16 years ago
In the PR_Poll implementation based on poll(), if a
PRPollDesc structure's fd field is NULL, we set the
corresponding pollfd structure's fd field to -1, but
we do not initialize its events field.  This is fine
because the poll man page says the events field is
ignored if the fd field is negative.  However,
apparently poll still reads the events field (at least
on Solaris), resulting in a UMR reported by Purify.
Assignee

Comment 1

16 years ago
Set the events field of a pollfd structure to 0 if we
set the fd field to -1.
Assignee

Comment 2

16 years ago
Same fix for the NSPR 4.1 branch.
Assignee

Updated

16 years ago
Attachment #124023 - Flags: review?(kirk.erickson)
Assignee

Comment 3

16 years ago
Comment on attachment 124025 [details] [diff] [review]
Proposed patch for NSPR 4.1 branch

Please ask your internal customer to test this patch
and see if it eliminates the UMR in PR_Poll.
Attachment #124025 - Flags: review?(kirk.erickson)

Comment 4

16 years ago
Comment on attachment 124023 [details] [diff] [review]
Proposed patch for NSPR TIP

Looks good.
Attachment #124023 - Flags: review?(kirk.erickson) → review+

Comment 5

16 years ago
I'll create binaries and try contacting Fred Batty at Sun.

I greped for PR_Poll and found that indeed selfserv doesn't
call, but sslstrength and ssltap may.  Perhaps I can reproduce
with one of these in the meantime.


Comment 6

16 years ago
This from Fred:

Hi, I have a lot of urgent work right now and probably won't be able to
verify this for several weeks. Why don't you go ahead and check in the fix,
and I'll mark the bug verified when I've had a chance to verify it. Thx
Assignee

Comment 7

16 years ago
Fixed on the NSPR tip (NSPR 4.4.1).
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → 4.4.1
Attachment #124025 - Flags: review?(kirk.erickson)
You need to log in before you can comment on or make changes to this bug.