Make zoomin and zoomout icons work

RESOLVED FIXED

Status

Core Graveyard
GFX: OS/2
RESOLVED FIXED
15 years ago
10 years ago

People

(Reporter: mkaply, Assigned: mkaply)

Tracking

({fixed1.4})

Trunk
Other
OS/2
fixed1.4

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

15 years ago
The function works, but IS/2 doesn't get the icons.
(Assignee)

Comment 1

15 years ago
Created attachment 124077 [details] [diff] [review]
Fix

pointers are already checked in.

I've changed the code to be a little more dynamic about loading pointers.

I know we have an empty slot at the beginning of the array and it is ugly.

Makes the math better
(Assignee)

Updated

15 years ago
Attachment #124077 - Flags: review?(pedemont)
Created attachment 124083 [details] [diff] [review]
Alternative fix

How about this?  Also, rather than hard coding IDC_COUNT, you could do this
"#define IDC_COUNT    IDC_HELP - IDC_BASE + 1" at the end of resource.h.
That second patch also contains a patch to rules.mk.  It seems that rc.exe
produces *.res files with all upper cases, such that "$(wildcard *.res)" in the
GARBAGE statement doesn't catch these files.  This means that generated .res
files on OS/2 don't get deleted.  I had to add an upper case equivalent in there.
(Assignee)

Updated

15 years ago
Attachment #124077 - Flags: review?(pedemont)
(Assignee)

Comment 4

15 years ago
Comment on attachment 124083 [details] [diff] [review]
Alternative fix

r=mkaply, sr=blizzard (OS/2 specific), a=mkaply
Attachment #124083 - Flags: superreview+
Attachment #124083 - Flags: review+
Attachment #124083 - Flags: approval1.4+
(Assignee)

Comment 5

15 years ago
Fixed on trunk and branch
Status: NEW → RESOLVED
Last Resolved: 15 years ago
Keywords: fixed1.4
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.