206909 - Make zoomin and zoomout icons work

Status: RESOLVED FIXED

(Core Graveyard :: GFX: OS/2, defect)

Description

[Mike Kaply [:mkaply]]

The function works, but IS/2 doesn't get the icons.

Comment 1

[Mike Kaply [:mkaply]]

Attachment: Fix

pointers are already checked in.

I've changed the code to be a little more dynamic about loading pointers.

I know we have an empty slot at the beginning of the array and it is ugly.

Makes the math better

Comment 2

[jhp (no longer active)]

Attachment: Alternative fix

How about this?  Also, rather than hard coding IDC_COUNT, you could do this
"#define IDC_COUNT    IDC_HELP - IDC_BASE + 1" at the end of resource.h.

Comment 3

[jhp (no longer active)]

That second patch also contains a patch to rules.mk.  It seems that rc.exe
produces *.res files with all upper cases, such that "$(wildcard *.res)" in the
GARBAGE statement doesn't catch these files.  This means that generated .res
files on OS/2 don't get deleted.  I had to add an upper case equivalent in there.

Comment 4

[Mike Kaply [:mkaply]]

Comment on attachment 124083 [details] [diff] [review]
Alternative fix

r=mkaply, sr=blizzard (OS/2 specific), a=mkaply

Comment 5

[Mike Kaply [:mkaply]]

Fixed on trunk and branch