2070284 - The customization panel should reset when closed

Status: RESOLVED FIXED

(Firefox :: New Tab Page, enhancement, P2)

Description

[Maxx Crawford [:maxx]]

STR:

1. Open new tab
2. Open customization panel
3. Expected: The panel should open
4. Select a wallpaper category to go to a subpanel
5. Click off of the panel entirely (anywhere else on the page)
6. Expected: The panel should close
7. Open the panel again (click the pencil icon)
8. Expected: The panel should be open to the root panel (showing themes, wallpapers, toggles, etc)
9. Actual: The panel is still in the wallpaper category subpanel

Comment 1

[Nina Pypchenko [:nina-py]]

This fix is relevant for both the wallpapers and themes subpanels - both need to reset and not reopen on the next opening of the Customize panel.

Comment 2

[Nina Pypchenko [:nina-py]]

Attachment: Bug 2070284 - The customization panel should reset when closed r=#home-newtab-wattle-reviewers-rotation!

Fix the wallpaper category and themes subpanels staying open across
closing and reopening the Customize panel. Bug 2037541 removed the
reset that closed the wallpaper subpanel when the panel closed, and the
themes subpanel added in Bug 2056304 never had one.

Rather than reinstate the old code, this makes a modest refactor. The
wallpaper subpanel's open state moves into Base next to the other three
subpanels, so all four are managed the same way and one method closes
them all once the dialog has finished closing.

New test coverage is in Jest; the two Enzyme files were only adjusted to
keep passing.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e2214fb04226
https://hg.mozilla.org/integration/autoland/rev/195c280e44b2
The customization panel should reset when closed r=Dre

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/195c280e44b2