Closed Bug 2070577 Opened 2 months ago Closed 1 month ago

Allow "permissions.setPermission" and "WebDriver:SetPermission" to set camera and microphone permissions

Categories

(Remote Protocol :: Agent, enhancement, P3)

enhancement

Tracking

(firefox158 fixed)

RESOLVED FIXED
158 Branch
Tracking Status
firefox158 --- fixed

People

(Reporter: saschanaz, Assigned: f3tchcodes, Mentored)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [lang=js][webdriver:m21][webdriver:external][wptsync upstream][webdriver:relnote])

Attachments

(2 external files)

This line is still there even though it's implemented now.

Good to know that this got fixed - even though it happend already quite some time ago.

Blocks: 1875064
Summary: Stop blocking camera/microphone → Allow "permissions.setPermission" to set camera and microphone permissions

It also affects the WebDriver command.

Component: WebDriver BiDi → Agent
Priority: -- → P3
Summary: Allow "permissions.setPermission" to set camera and microphone permissions → Allow "permissions.setPermission" and "WebDriver:SetPermission" to set camera and microphone permissions
Whiteboard: [lang=js][webdriver:backlog]
Mentor: aborovova

I'd like to work on this if it's still available.

Hey f3tch, it's available, so go ahead. :) I'll assign the bug to you.
Let me know if you have any questions!

Assignee: nobody → f3tch.169
Status: NEW → ASSIGNED
Attachment #9644774 - Attachment description: WIP: Bug 2070577 - Allow permissions.setPermission and WebDriver:SetPermission to set camera and microphone permissions → Bug 2070577 - Allow permissions.setPermission and WebDriver:SetPermission to set camera and microphone permissions. r?Sasha
Blocks: 2073665

f3tch, thanks for the patch. Maybe you can check as well if you could add tests for both (if doable) to testing/web-platform/tests/webdriver/tests/bidi/external/permissions/set_permission/set_permission.py?

Updated! I added tests for both camera and microphone, and Sasha requested parameterizing the test so I've also made that change.

Attachment #9645891 - Attachment description: Bug 2070577 - Add tests for camera and microphone permissions. r?Sasha → Bug 2070577 - [wdspec] Add tests for camera and microphone permissions. r?Sasha
Pushed by aborovova@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/e8b9b546706b https://hg.mozilla.org/integration/autoland/rev/dffd93685a1e Allow permissions.setPermission and WebDriver:SetPermission to set camera and microphone permissions. r=Sasha,webdriver-reviewers https://github.com/mozilla-firefox/firefox/commit/03bcfb78e7cf https://hg.mozilla.org/integration/autoland/rev/f45a7b12411f [wdspec] Add tests for camera and microphone permissions. r=Sasha,webdriver-reviewers

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/62852 for changes under testing/web-platform/tests

Whiteboard: [lang=js][webdriver:backlog] → [lang=js][webdriver:backlog], [wptsync upstream]
Pushed by abutkovits@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/a52bcbe012f7 https://hg.mozilla.org/integration/autoland/rev/dbd84acdb48f Revert "Bug 2070577 - [wdspec] Add tests for camera and microphone permissions. r=Sasha,webdriver-reviewers" for causing failures at GUM-deny.https.html.
Flags: needinfo?(f3tch.169)
Pushed by aborovova@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/b159abdc6857 https://hg.mozilla.org/integration/autoland/rev/a1a77f9f0a9c Allow permissions.setPermission and WebDriver:SetPermission to set camera and microphone permissions. r=Sasha,webdriver-reviewers https://github.com/mozilla-firefox/firefox/commit/a22fb216815d https://hg.mozilla.org/integration/autoland/rev/b56b2037946f [wdspec] Add tests for camera and microphone permissions. r=Sasha,webdriver-reviewers

Oh, I was looking in the same direction and was just about to make that change, but looks like you already fixed it. Thanks!

Upstream PR was closed without merging

Hey Sasha, could you please check this? The test PR was closed without getting merged. Is that normal?

(In reply to f3tch [:f3tchcodes] from comment #16)

Hey Sasha, could you please check this? The test PR was closed without getting merged. Is that normal?

The mentioned PR https://github.com/web-platform-tests/wpt/pull/62852 is still open. It was closed before due to the backout of the patch. It will be merged once your patch lands on mozilla-central.

Oh alright, thank you!

Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 158 Branch
Whiteboard: [lang=js][webdriver:backlog], [wptsync upstream] → [lang=js][webdriver:m21][webdriver:external][wptsync upstream]

Upstream PR merged by moz-wptsync-bot

Whiteboard: [lang=js][webdriver:m21][webdriver:external][wptsync upstream] → [lang=js][webdriver:m21][webdriver:external][wptsync upstream][webdriver:relnote]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: