Allow "permissions.setPermission" and "WebDriver:SetPermission" to set camera and microphone permissions
Categories
(Remote Protocol :: Agent, enhancement, P3)
Tracking
(firefox158 fixed)
| Tracking | Status | |
|---|---|---|
| firefox158 | --- | fixed |
People
(Reporter: saschanaz, Assigned: f3tchcodes, Mentored)
References
(Blocks 2 open bugs)
Details
(Whiteboard: [lang=js][webdriver:m21][webdriver:external][wptsync upstream][webdriver:relnote])
Attachments
(2 external files)
This line is still there even though it's implemented now.
Comment 1•2 months ago
|
||
Good to know that this got fixed - even though it happend already quite some time ago.
Comment 2•1 month ago
|
||
It also affects the WebDriver command.
Updated•1 month ago
|
| Assignee | ||
Comment 3•1 month ago
|
||
I'd like to work on this if it's still available.
Comment 4•1 month ago
|
||
Hey f3tch, it's available, so go ahead. :) I'll assign the bug to you.
Let me know if you have any questions!
| Assignee | ||
Comment 5•1 month ago
|
||
Updated•1 month ago
|
Comment 6•1 month ago
|
||
f3tch, thanks for the patch. Maybe you can check as well if you could add tests for both (if doable) to testing/web-platform/tests/webdriver/tests/bidi/external/permissions/set_permission/set_permission.py?
| Assignee | ||
Comment 7•1 month ago
|
||
Updated! I added tests for both camera and microphone, and Sasha requested parameterizing the test so I've also made that change.
| Assignee | ||
Comment 8•1 month ago
|
||
Updated•1 month ago
|
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/62852 for changes under testing/web-platform/tests
Comment 11•1 month ago
|
||
Comment 12•1 month ago
|
||
Backed out for causing failures at GUM-deny.https.html.
Backout link: https://hg.mozilla.org/integration/autoland/rev/dbd84acdb48f
Failure log: https://treeherder.mozilla.org/logviewer?job_id=594660324&repo=autoland&task=bbhomA5vRh66Q4isjwH84A.0&lineNumber=4116
Updated•1 month ago
|
Comment 13•1 month ago
|
||
| Assignee | ||
Comment 14•1 month ago
|
||
Oh, I was looking in the same direction and was just about to make that change, but looks like you already fixed it. Thanks!
Upstream PR was closed without merging
| Assignee | ||
Comment 16•1 month ago
|
||
Hey Sasha, could you please check this? The test PR was closed without getting merged. Is that normal?
Comment 17•1 month ago
|
||
(In reply to f3tch [:f3tchcodes] from comment #16)
Hey Sasha, could you please check this? The test PR was closed without getting merged. Is that normal?
The mentioned PR https://github.com/web-platform-tests/wpt/pull/62852 is still open. It was closed before due to the backout of the patch. It will be merged once your patch lands on mozilla-central.
| Assignee | ||
Comment 18•1 month ago
|
||
Oh alright, thank you!
Comment 19•1 month ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/a1a77f9f0a9c
https://hg.mozilla.org/mozilla-central/rev/b56b2037946f
Updated•1 month ago
|
Upstream PR merged by moz-wptsync-bot
Updated•1 month ago
|
Description
•