GetHomePageGroup should treat GetLocalizedUnicharPref as noncritical

RESOLVED EXPIRED

Status

SeaMonkey
UI Design
P5
minor
RESOLVED EXPIRED
15 years ago
8 years ago

People

(Reporter: timeless, Assigned: timeless)

Tracking

Trunk
x86
Windows 2000

Firefox Tracking Flags

(Not tracked)

Details

(Assignee)

Description

15 years ago
712 nsresult GetHomePageGroup(nsIPref* aPref, PRUnichar** aResult)
713 {
714   nsresult rv;
715 
716   nsXPIDLString uri;
717   rv = aPref->GetLocalizedUnicharPref(PREF_BROWSER_STARTUP_HOMEPAGE,
getter_Copies(uri));
718   if (NS_FAILED(rv))
719     return rv;
720 
721   PRInt32 count = 0;
722   rv = aPref->GetIntPref("browser.startup.homepage.count", &count);
723 
724   // if we couldn't get the pref (unlikely) or only have one homepage
725   if (NS_FAILED(rv) || count <= 1) {
726     *aResult = ToNewUnicode(uri);
727     return NS_OK;
728   }

I managed to make 717 fail. I think it should be treated the same way 722 is, as
nonfatal.

GetHomePageGroup(nsIPref * 0x004596d0, unsigned short * * 0x004cabb0) line 718
nsBrowserContentHandler::GetDefaultArgs(nsBrowserContentHandler * const
0x00479944, unsigned short * * 0x004cabb0) line 800 + 21 bytes
nsAppShellService::OpenBrowserWindow(int -1, int -1) line 1298 + 62 bytes
nsAppShellService::Ensure1Window(nsAppShellService * const 0x00459570,
nsICmdLineService * 0x0045b0c0) line 1236 + 16 bytes
main1(int 1, char * * 0x00424550, nsISupports * 0x00438310) line 1233 + 41 bytes
main(int 1, char * * 0x00424550) line 1647 + 37 bytes
WinMain(HINSTANCE__ * 0x00400000, HINSTANCE__ * 0x00400000, char * 0x00133392,
HINSTANCE__ * 0x00400000) line 1671 + 23 bytes
WinMainCRTStartup() line 330 + 54 bytes
KERNEL32! SetUnhandledExceptionFilter + 92 bytes

Because GetHomePageGroup fails, nsBrowserContentHandler::GetDefaultArgs and 
nsAppShellService::OpenBrowserWindow also fail.
Product: Core → Mozilla Application Suite
(Assignee)

Updated

12 years ago
Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: -- → P5
(Assignee)

Updated

10 years ago
Component: XP Apps: GUI Features → UI Design

Comment 1

9 years ago
MASS-CHANGE:
This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state.

If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way.
If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar).
If no action happens within the next few months, we move this bug report to an EXPIRED state.

Query tag for this change: mass-UNCONFIRM-20090614
Status: NEW → UNCONFIRMED

Comment 2

8 years ago
MASS-CHANGE:
This bug report is registered in the SeaMonkey product, but still has no comment since the inception of the SeaMonkey project 5 years ago.

Because of this, we're resolving the bug as EXPIRED.

If you still can reproduce the bug on SeaMonkey 2 or otherwise think it's still valid, please REOPEN it and if it is a platform or toolkit issue, move it to the according component.

Query tag for this change: EXPIRED-20100420
Status: UNCONFIRMED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → EXPIRED
You need to log in before you can comment on or make changes to this bug.