207171 - nsBlockAccessible inheritence incorrect with respect to documents

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Aaron Leventhal]

nsDocAccessible should inherit from nsBlockAccessible.
nsOuterDocAccessible should inherit from nsAccessibleWrap.

It is nsDocAccessible that might have overlapping children. nsOuterDocAccessible
only ever has 1 child, the nsDocAccessible.

This was a mistake I created when I mad 2 accessible objects for the inner and
outer document objects.

Comment 1

[Aaron Leventhal]

Attachment: Fixes inheritence

Comment 2

[Kyle Yuan]

Comment on attachment 124239 [details] [diff] [review]
Fixes inheritence

r=kyle

Comment 3

[Alec Flett]

Comment on attachment 124239 [details] [diff] [review]
Fixes inheritence

sr=alecf

Comment 4

[Aaron Leventhal]

checked in

Comment 5

[Aaron Leventhal]

Comment on attachment 124239 [details] [diff] [review]
Fixes inheritence

Seeking a= for accessibility patch that has baked on the trunk for 2 weeks.

Comment 6

[Asa Dotzler [:asa]]

Comment on attachment 124239 [details] [diff] [review]
Fixes inheritence

moving approval request forward.

Comment 7

[Mike Kaply [:mkaply]]

Comment on attachment 124239 [details] [diff] [review]
Fixes inheritence

a=mkaply for 1.4.1.

Comment 8

[Mike Kaply [:mkaply]]

please add the fixed1.4.1 keyword when this is checked in.

Comment 9

[Robert Pollak]

According to Bonsai, this approved patch is still not checked in for 1.4.1.

Comment 10

[Aaron Leventhal]

I'm not planning to check it in.

I never got enough approvals on other accessibilty bugs to make it worth it. This alone isn't going 
to make 1.4 accessible.

On with accessibility in the trunk I say. Own it and check it in, if you want. Sun might be interested.

Comment 11

[Robert Pollak]

CCing mkaply, since he has set the blocking1.4.x+ flag.

Comment 12

[Kyle Yuan]

Same as Aaron said, we are also interested to move *all* of the accessibility
patches from trunk to 1.4 branch. Only 3 patches won't make the accessibility
feature much better.

Comment 13

[Robert Pollak]

Which patches are these? Shouldn't they be "blocking1.4.x+", too?

Comment 14

[Kyle Yuan]

The list is fairly long:

a= bug 207171: nsBlockAccessible inheritence is wrong, affects
AccessibleObjectFromPoint() -- Must add #include "nsIContent.h to
nsOuterDocAccessible.h
a= bug 207486: should not report state_expanded for non-container tree nodes
a= bug 207554: crash in nshtmlselectoptionaccessible::getaccnextsibling() -
http://climate.netscape.com/reports/SingleIncidentInfo.cfm?dynamicBBID=20543829
a? bug 207950: add capabilities to ISimpleDOMNode -- has what Freedom Sci needs
(patch is messed up, need to make sure it gets get_localInterface)
a? bug 207487: not reporting accessible name for xul <textbox>es
a? bug 208265: accessibility can crash after profile manager window closes
a? bug 208781: No accessible focus events fired for list items in profile manager.
a? bug 208812: fire internal nsIObserver accessibility event for internal xpcom
accessibility clients, don't forget to add nsIAccessibleCaret.h to
widget/src/windows
a= bug 208460: get rid of nsIDOM3Node.h dependency
a? bug 208922: Make nsIAccessNode consumable for in process accessibility clients
a? bug 210069: fix in process accessibility events to not leak
a? bug 209990: fixes more instability
a? bug 208898: Fire accessible events for interal accessibiltiy clients for all
new documents and windows that are created
a? bug 208803: need xp way to destroy doc accessibles in cache when docs go
away. Also works with internal accessibility clients. 

We still have 10 bugs in the waiting list. (I've marked most of them
blocking1.4.x? today).