Use nsScriptableUnicodeConverter::Finish()

RESOLVED FIXED

Status

defect
RESOLVED FIXED
16 years ago
15 years ago

People

(Reporter: kazhik, Assigned: rginda)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: cz-patch)

Attachments

(1 attachment, 1 obsolete attachment)

517 bytes, patch
rginda
: review+
Details | Diff | Splinter Review
(Reporter)

Description

16 years ago
nsScriptableUnicodeConverter::Finish() isn't used in Chatzilla,
because it doesn't work in <= mozilla 1.2. But we can ignore
the old versions after the release of mozilla 1.4, which is
declared to "replace the 1.0 branch as the stable development path".
(Reporter)

Comment 1

16 years ago
Posted patch patch v1 (obsolete) — Splinter Review
(Reporter)

Updated

16 years ago
Attachment #124243 - Flags: review?(rginda)
(Assignee)

Comment 2

16 years ago
Comment on attachment 124243 [details] [diff] [review]
patch v1

I'm not ready to drop support for old mozilla's yet.  If we're going to do this
it has to work on 1.0 and up.
Attachment #124243 - Flags: review?(rginda) → review-
(Assignee)

Updated

16 years ago
Status: NEW → ASSIGNED
Depends on: 210744
(Assignee)

Comment 3

16 years ago
The chatzilla 0.9.x branch has landed on the trunk and should be available in
tomorrow's nightly build.  If you believe this bug has not actually been fixed,
please repoen it.
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
(Reporter)

Comment 4

16 years ago
Posted patch patchSplinter Review
The current code uses Finish() in wrong way.
Attachment #124243 - Attachment is obsolete: true
(Reporter)

Comment 5

16 years ago
reopen.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Reporter)

Updated

16 years ago
Attachment #131779 - Flags: review?(rginda)

Updated

16 years ago
Whiteboard: cz-patch
(Assignee)

Comment 6

16 years ago
Comment on attachment 131779 [details] [diff] [review]
patch

r=rginda
Attachment #131779 - Flags: review?(rginda) → review+
(Assignee)

Comment 7

16 years ago
fixed in 0.9.40
Status: REOPENED → RESOLVED
Last Resolved: 16 years ago16 years ago
Resolution: --- → FIXED
Product: Core → Other Applications
You need to log in before you can comment on or make changes to this bug.