207425 - Memory leak in nsHTTPCompressConv.cpp

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[jhp (no longer active)]

One of our customers was seeing a memory leak on the order of about 20 Mb every
5 to 10 minutes.  Eventually, they would exhaust all their memory and mozilla
would crash.  This was on an OS/2 machine.  They were also able to recreate the
problem on a Win32 machine, but it took much longer for Mozilla to crash.

Eventually, the issue was tracked to a memory leak in nsHTTPCompressConv.cpp. 
It appears that the code is inflating a string, but never getting a Z_STREAM_END.

Comment 1

[jhp (no longer active)]

This bug is very similar to the one in bug 198133.  CCing those involved in that
bug.

Comment 2

[jhp (no longer active)]

Attachment: fix leak

This patch greatly reduced the memory leaks seen by our customer.  Of course,
this is just a quick fix.  The correct fix would be to figure out why the code
is not getting Z_STREAM_END.

Comment 3

[Alec Flett]

Comment on attachment 124397 [details] [diff] [review]
fix leak

I noticed that we weren't getting Z_STREAM_END there as well. Maybe this is why
my netscape processes are hitting 150 megs over the course of a few days.

sr=alecf

lets get this in ASAP so we can see if this cleans up major leaks - darin is
still gone for another week. 

doug, can you review this? When darin gets back we can double-check that this
is the correct fix. If this is good on the 1.5alpha branch, I'd like to see if
we can get this into 1.4final

Comment 4

[Doug Turner (:dougt)]

Comment on attachment 124397 [details] [diff] [review]
fix leak

darin sent me mail about this.	r=dougt

Comment 5

[Alec Flett]

cool, that was quick. Ok, I've landed this on the trunk 

(Well, I had to change the name of the Initialized/Ended variables to match the
trunk)

lets see what happens.

Comment 6

[Alec Flett]

Comment on attachment 124397 [details] [diff] [review]
fix leak

Now that this is landed, I'd like to request that this goes into 1.4 -
hopefully we're not too late!

Comment 7

[Asa Dotzler [:asa]]

Comment on attachment 124397 [details] [diff] [review]
fix leak

a=asa (on behalf of drivers) for checkin to the 1.4 branch.

Comment 8

[Olivier Cahagne]

if this was checked in on 1.4 branch, should this be marked Fixed ?

Comment 9

[Mike Kaply [:mkaply]]

This was checked in everywhere.

Comment 10

[timeless]

This is not on the 1.4 branch, it has approval but isn't there:
http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/netwerk/streamconv/converters/nsHTTPCompressConv.cpp&rev=MOZILLA_1_4_BRANCH&mark=1.20
http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/netwerk/streamconv/converters/nsHTTPCompressConv.cpp&mark=1.20