207487 - No accessible name for XUL <textbox>

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Aaron Leventhal]

When a XUL textbox is in the accessible tree, it has an empty name, even when
there is a <label> associated with it.

For example, see the textbox with the label "Subject or Sender Contains" in mail
(the quick search field).

Comment 1

[Aaron Leventhal]

Attachment: Create accessible from XBL where XUL node is, not from anonymous html:input child

The problem was that nsFormControlAccessible::GetAccName thought this was an
html node, and didn't see that it was a XUL node or it's context within the
document.

Comment 2

[Kyle Yuan]

Comment on attachment 124444 [details] [diff] [review]
Create accessible from XBL where XUL node is, not from anonymous html:input child

Yes, I also met this issue and tried to hack on GetAccName. But your fix is
neater. One thing I concerned is that we always assume mDOMNode in
nsHTMLTextFieldAccessible is either a nsIDOMHTMLTextAreaElement or a
nsIDOMHTMLInputElement.  Will this new XUL element affect that?

Comment 3

[Aaron Leventhal]

Comment on attachment 124444 [details] [diff] [review]
Create accessible from XBL where XUL node is, not from anonymous html:input child

Good catch, I'll have to put up a new patch with that in mind.

Comment 4

[Aaron Leventhal]

Attachment: Uses new nsIDOMXULTextboxElement interface to get accessible value, and anonymous html input

The fields for an nsIDOMXULTextboxElement already existed, but there was just
no idl file yet. Looks like an oversight to me.

Comment 5

[Aaron Leventhal]

Attachment: Same as last patch, but I don't need to QI nsIDOMHTMLInputElement to nsIDOMNode, before passing it as an argument when creating the temp accessible -- I can use automatic conversion

Comment 6

[Kyle Yuan]

Comment on attachment 124683 [details] [diff] [review]
Same as last patch, but I don't need to QI nsIDOMHTMLInputElement to nsIDOMNode, before passing it as an argument when creating the temp accessible --  I can use automatic conversion

r=kyle
I'm okay with the accessibility changes, but I'm not sure about the xul/idl
changes. Please also ask some xul guru to r/sr= this. 

two nits/questions:
1) please encapsulate the code referring to nsIDOMXULTextboxElement into a
#ifdef MOZ_XUL block.
2) 
-      <property name="maxlength"  onset="this.inputField.maxlength = val;
return val;"
+      <property name="maxLength"  onset="this.inputField.maxlength = val;
return val;"
what's the need to change this?

Comment 7

[Aaron Leventhal]

Kyle,

Thanks for reminding me about MOZ_XUL.

I was changing the name maxLength to be consistent with the capitalization in
textLength. Our javascript property naming convention is interCaps with a
lowercase first letter.

Comment 8

[Kyle Yuan]

I questioned that because maxlength also appears in the xbl:inherits attribute, 
see:
http://lxr.mozilla.org/seamonkey/source/xpfe/global/resources/content/bindings/t
extbox.xml#22
So I'm not sure whether this will break the xbl:inherits if xbl is using a case 
sensitive string comparison.

Comment 9

[Aaron Leventhal]

No, it doesn't break that because inherits="" deals with XML attributes, not
javascript properties. It's normal for the attribute to keep the all lowercase
name, while the javascript property gets interCaps.

Comment 10

[Alec Flett]

Comment on attachment 124683 [details] [diff] [review]
Same as last patch, but I don't need to QI nsIDOMHTMLInputElement to nsIDOMNode, before passing it as an argument when creating the temp accessible --  I can use automatic conversion

-      <property name="maxlength"  onset="this.inputField.maxlength = val;
return val;"
+      <property name="maxLength"  onset="this.inputField.maxlength = val;
return val;"

woah, you SURE nobody else is using this?

sr=alecf assuming you've made sure.

Comment 11

[Aaron Leventhal]

I've made sure, because maxlength is not used as a javascript property within
textbox.xml, and there was no interface that used maxlength in lowercase that
this implements, so nothing outside could use it.

Comment 12

[Aaron Leventhal]

Comment on attachment 124683 [details] [diff] [review]
Same as last patch, but I don't need to QI nsIDOMHTMLInputElement to nsIDOMNode, before passing it as an argument when creating the temp accessible --  I can use automatic conversion

Seeking a= for accessibility patch that has baked on the trunk for 2 weeks.

Comment 13

[Asa Dotzler [:asa]]

Comment on attachment 124683 [details] [diff] [review]
Same as last patch, but I don't need to QI nsIDOMHTMLInputElement to nsIDOMNode, before passing it as an argument when creating the temp accessible --  I can use automatic conversion

moving approval request forward.

Comment 14

[Asa Dotzler [:asa]]

Comment on attachment 124683 [details] [diff] [review]
Same as last patch, but I don't need to QI nsIDOMHTMLInputElement to nsIDOMNode, before passing it as an argument when creating the temp accessible --  I can use automatic conversion

This is not going to make 1.4.1.  Please renominate after 1.4.1 ships if you'd
like to get this in for 1.4.2.

Comment 15

[Alex Vincent [:WeirdAl]]

fixed on June 4, 2003 according to bonsai 

Comment 16

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1527381