If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Status

()

Core
Internationalization
--
trivial
RESOLVED FIXED
15 years ago
9 years ago

People

(Reporter: Andrew Taylor, Assigned: Andrew Taylor)

Tracking

(Blocks: 1 bug, {footprint})

Trunk
footprint
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

15 years ago
There are a number of variables in mozilla/intl that could be made const. 
Making them const allows some optimizations not otherwise available, such as
sharing more data between multiple running instances.

Comment 1

15 years ago
yay! so glad to see more of these bugs :)
(Assignee)

Comment 2

15 years ago
Created attachment 124481 [details] [diff] [review]
constifies some variables in intl
[Checkin: Comment 4]

Here is a patch that constifies some variables in intl.  Interestingly, the
file  intl/chardet/src/nsCyrillicClass.h is automatically generated by
GenCyrllicClass.cpp which already outputs static const variables, but the copy
in CVS has only static variables.

This patch fixes that, as well as updating some method signatures to avoid
"casting away const" type warnings.  All told, it makes about 1k of data const.

Comment 3

15 years ago
Comment on attachment 124481 [details] [diff] [review]
constifies some variables in intl
[Checkin: Comment 4]

nice! sr=alecf
Attachment #124481 - Flags: superreview+
(Assignee)

Updated

15 years ago
Attachment #124481 - Flags: review?(bz-bugspam)
Attachment #124481 - Flags: review?(bz-bugspam) → review+
Checked in to the 1.5a trunk.
Status: NEW → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
Blocks: 74803
Flags: in-testsuite-
Attachment #124481 - Attachment description: constifies some variables in intl → constifies some variables in intl [Checkin: Comment 4]
You need to log in before you can comment on or make changes to this bug.