207797 - a few windows tinderbox client patches

Status: RESOLVED FIXED

(Webtools Graveyard :: Tinderbox, defect, P2)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

In the process of setting up a Windows tinderbox client, I've fixed a few things.

bryner has a patch for fixing the cygwin-perl-only '\r' removal (since the '\r'
isn't there with some versions).  (I just commented it out, bryner has the right
fix.)

I also had trouble running the codesize test unless the arguments were passed as
a real array.  I'll attach a patch to fix that.  It seems that someone else had
similar problems recently since there was a similar checkin recently for the
DomToTextConversionTest (rev. 1.241 of build-seamonkey-util.pl).

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

(The commented out line here shouldn't be checked in.)

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 124643 [details] [diff] [review]
patch

bryner: I forget if you had a good way to get the last character of a string or
was just using regular expressions.  But you could review the rest of this, and
perhaps tell me what you had in your tree?

Comment 3

[Brian Ryner (not reading)]

Comment on attachment 124643 [details] [diff] [review]
patch

>--- ..\mozilla\tools\tinderbox\build-seamonkey-util.pl	2003-05-17 01:34:44.000000000 -0700
>+++ build-seamonkey-util.pl	2003-05-31 14:55:42.000000000 -0700
>@@ -1841,7 +1841,7 @@
>-        chop($rv) if ($^O eq 'cygwin'); # cygwin perl doesn't chomp dos-newlinesproperly so use chop.
>+        #chop($rv) if ($^O eq 'cygwin'); # cygwin perl doesn't chomp dos-newlinesproperly so use chop.

What I did in my tree was just:

chop($rv) if ($rv =~ /\r$/);

We probably want that instead of commenting it out.

r=me on the rest of it.

Comment 4

[Chris McAfee]

the array arg change happened courtesy seawood, I think there
were some straggling cases (external builds, etc.) that were
broken; DomToTextConversion may have been one of those.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in to trunk, 2003-08-13 15:06 -0700.