Closed Bug 207908 Opened 21 years ago Closed 21 years ago

Attempts to drag (move) a line from tree control (thread pane, bookmarks, etc) hang client

Categories

(Core :: XUL, defect)

x86
All
defect
Not set
blocker

Tracking

()

VERIFIED FIXED

People

(Reporter: ralvy, Assigned: Bienvenu)

References

Details

(Keywords: hang, regression)

Attachments

(2 files)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.3a; MultiZilla v1.1.32 final) Gecko/20030601
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.3a; MultiZilla v1.1.32 final) Gecko/20030601

Attempts to drag (move) a message from InBox to another folder locks Mail
client. Haven't seen this until this build.

Reproducible: Always

Steps to Reproduce:
1. Mouse select a message in InBox
2. Drag to a folder
3.

Actual Results:  
Lock up.

Expected Results:  
Obvious
and which build Do you use ?
This bug is invalid if rv:1.3a because it's to old.
(But the UA string could be wrong due to multizilla)
It's found in Build 2003060108. I thought I posted the bug report with that
build. Apparently not.
Reporter again: the build 2003060108 is the one dowloaded as the latest Nightly,
even though it reports rv:1.3a
Reproducible with Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5a)
Gecko/20030601
Confirming with linux 2003060122 trunk
wfm with 2003053122
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows 2000 → All
Confirming with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5a)
Gecko/20030601
Using the context menu's "Move To" works though.
Severity: normal → blocker
Keywords: hang, regression
This bug _IS_ confirmend for all platforms (win32, Linux..) and we don't need
new "confirmed ..." comments - Thanks

regressioin between 2003053122 and 2003060122
Just tested buildID 2003060104 and no hang but does happen on buildID 2003060108
on Win XPSP1, so regression happens sometime between those two builds.
So bug 207798 is the cause.
I'm not able to reproduce this - I'll keep trying.
Attached file stacktrace during hang
thx, yeah, I thought so. It wasn't my checkin. It was timeless. That explains
why the move menu worked but drag+drop failed.

http://bugzilla.mozilla.org/show_bug.cgi?id=207318
I'm updating my tree to get timeless'es change to make sure that backing him out
fixes things. You might try things like drag drop in the bookmarks window to see
if it has the same problem.
Ok, bienvenu, sorry for wrongly accusing you... it looked so close, but when I
looked at your patch I almost knew it couldn't be that one...
Bug 207603 and bug 207318 are the other checkins during the time in question and
my next guess would be the latter one...
Well there are certainly some bugs opened recently to do with hangs in there, so
maybe this bug's summary/component/etc need to be tweaked and some duping done.
For example bug 207940 and bug 207964
adjusting summary
Component: Mail Window Front End → XP Toolkit/Widgets: Trees
Product: MailNews → Browser
Summary: Attempts to drag (move) a message from InBox to another folder locks Mail client → Attempts to drag (move) a line from tree control (thread pane, bookmarks, etc) hang client
*** Bug 207940 has been marked as a duplicate of this bug. ***
*** Bug 207964 has been marked as a duplicate of this bug. ***
*** Bug 207943 has been marked as a duplicate of this bug. ***
*** Bug 207901 has been marked as a duplicate of this bug. ***
Also affects addressbook and personal toolbar
*** Bug 207981 has been marked as a duplicate of this bug. ***
From the patch in bug 207318:

> -  mView->GetParentIndex(mDropRow, &parentIndex);
> -  while (parentIndex >= 0) {
> +  while (NS_SUCCEEDED(mView->GetParentIndex(mDropRow, &parentIndex)) &&
> +         parentIndex >= 0) {
>      mValueArray.RemoveValue(parentIndex);
>      mView->GetParentIndex(parentIndex, &parentIndex);
>    }

That looks like a infite loop... (GetParentIndex called with mDropRow every loop)
*** Bug 207987 has been marked as a duplicate of this bug. ***
I'll come up with a better patch than timeless'es.

the old code did NOT  have this call every time through the loop:

NS_SUCCEEDED(mView->GetParentIndex(mDropRow, &parentIndex)
Attached patch proposed fixSplinter Review
Jan, can I get a review for this fix? thx.
Comment on attachment 124748 [details] [diff] [review]
proposed fix

sr=sspitzer, once you get jan to review.

thanks for fixing this, david.
Attachment #124748 - Flags: superreview+
Attachment #124748 - Flags: review?(varga)
over to david.
Assignee: sspitzer → bienvenu
Comment on attachment 124748 [details] [diff] [review]
proposed fix

bah, mea culpa for not catching this while I was reviewing timeless's patch
r=varga
Attachment #124748 - Flags: review+
fix checked in.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Just to confirm I verified this bug was not in the branch builds 6-1 and 6-2. Esther
*** Bug 208053 has been marked as a duplicate of this bug. ***
*** Bug 208091 has been marked as a duplicate of this bug. ***
*** Bug 208105 has been marked as a duplicate of this bug. ***
*** Bug 208116 has been marked as a duplicate of this bug. ***
*** Bug 208054 has been marked as a duplicate of this bug. ***
V. 2003060304 PC/WinXP
Status: RESOLVED → VERIFIED
Verified internally using 20030503 trunk build on winxp.
*** Bug 208206 has been marked as a duplicate of this bug. ***
From my point of view fixed with
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5a) Gecko/20030604
Thanks, Wolfgang
*** Bug 209186 has been marked as a duplicate of this bug. ***
This bug has resurfaced with Build 20030614, however to make it happen, you must
Select more than one message in the InBox and then attempt to drag both to
another folder at one time. I have done this with 2 message Selected, repeatedly
causing a  crash.
Drag/drop moving of multiple bookmarks causes crash in Mozilla/5.0 (Windows; U;
Windows NT 5.0; en-US; rv:1.5a) Gecko/20030617 on Windows 2000.  Crash is
reproducible, and this problem does not seem to have remained fixed.
A crash is of course not fixed.
The summary is very clear "freeze" and see also the "hanf" keyword.
You would see the word "crash" if this also fixed a crash.
if you're experiencing *anything* with a current build, then it isn't this bug.
please find some other bug in which to discuss your problem.
From reporter: Based on the very last comment, I'm not sure if I should begin a
new bug on this. Though the original bug I reported involved a *hang* when
moving a *single* message from InBox to a folder, I only recently noticed that,
even though the latter was fixed, a *crash* occurs if moving *two* messages from
the InBox to a folder at the same time.
ralph: sorry, your bug was hijacked, file a new one.
Attachment #124748 - Flags: review?(varga)
This problem (as originally reported, as I understand it) was fixed in some
builds, as recently as 20030618 under MacOSX.  Broken again in 20030620.

Bug 208147 seems to track a similar problem.
Component: XP Toolkit/Widgets: Trees → XUL
QA Contact: esther → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: