Closed Bug 208007 Opened 23 years ago Closed 23 years ago

Mishandling of HPS's in nsDrawingSurfaceOS2.cpp

Categories

(Core Graveyard :: GFX: OS/2, defect)

x86
OS/2
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jhpedemonte, Assigned: mkaply)

Details

(Keywords: fixed1.4)

Attachments

(1 file)

We are mishandling some HPS's in nsDrawingSurfaceOS2.cpp. Specifically, in a couple of the classes, we are deleting HPS's that are not created by the class. May be causing some display corruption.
Attached patch patchSplinter Review
Create a new member variable in the parent class so a class object will know if it created the HPS and therefore needs to be deleted. Also, clean up some of the destructors.
Attachment #124754 - Flags: review?(mkaply)
Comment on attachment 124754 [details] [diff] [review] patch r=mkaply sr=blizzard (OS/2 specific) a=mkaply for 1.4
Attachment #124754 - Flags: superreview+
Attachment #124754 - Flags: review?(mkaply)
Attachment #124754 - Flags: review+
Attachment #124754 - Flags: approval1.4+
Fixed on trunk and branch
Status: NEW → RESOLVED
Closed: 23 years ago
Keywords: fixed1.4
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: