Closed Bug 20823 Opened 20 years ago Closed 20 years ago

[SKINS] navigator.xul improperly loads the bookmarks master skin file

Categories

(Core :: XUL, defect, P2)

x86
Other
defect

Tracking

()

VERIFIED FIXED

People

(Reporter: hyatt, Assigned: bugs)

References

Details

(Whiteboard: [pdt+])

No package should ever load the master skin file of another package.  If you
want to share stuff between bookmarks and navigator, use a differently named
skin file, e.g., chrome://bookmarks/skin/whatever.css.

The master skin file is now reserved for defining the default look of the
component.
Status: NEW → ASSIGNED
Priority: P3 → P2
Target Milestone: M13
I have been bad.
I will fix it.
Assignee: slamm → rgoodger
Status: ASSIGNED → NEW
Target Milestone: M13 → M14
Ben, you are now the owner of all our "skins" issues.
Status: NEW → ASSIGNED
Adding [beta], since we will be localizig it, and making a dependency for 12394.
Blocks: 12394
Summary: [Skins] navigator.xul improperly loads the bookmarks master skin file → [BETA][Skins] navigator.xul improperly loads the bookmarks master skin file
Summary: [BETA][Skins] navigator.xul improperly loads the bookmarks master skin file → [FEATURE][SKINS] navigator.xul improperly loads the bookmarks master skin file
Re-summarize.
Summary: [FEATURE][SKINS] navigator.xul improperly loads the bookmarks master skin file → [SKINS] navigator.xul improperly loads the bookmarks master skin file
Oooops, not a feature.  Just a bug.  Shhhh ...
These are pre-requisites of localizable chrome. Marking them [BETA]. Please fix
them by M14 so that we can be ready for localization. To make the chrome
localizable, the font name, font size, and UI geometry setting needs to be
externalized and move to chrome/[package]/locale/*.css.

Adding lyecies, amasri, and tao into CC list.


Thanks
Summary: [SKINS] navigator.xul improperly loads the bookmarks master skin file → [BETA][SKINS] navigator.xul improperly loads the bookmarks master skin file
BULK MOVE: Changing component from XUL to XP Toolkit/Widgets: XUL.  XUL 
component will be deleted.
Component: XUL → XP Toolkit/Widgets: XUL
At the request of jevering, I'm nominating this as a "beta1" blocker.
Keywords: beta1
Whiteboard: [pdt+]
Summary: [BETA][SKINS] navigator.xul improperly loads the bookmarks master skin file → [SKINS] navigator.xul improperly loads the bookmarks master skin file
fix checked in
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
I'm wondering if amasri can verify this, if not, send it back to me
QA Contact: paulmac → amasri
the problem here is that it was importing the skin file of another package:

<?xml-stylesheet href="chrome://bookmarks/skin/"?>

a xul file in a package should not import the skin file of another package 
because one cannot guarantee the presence of that other package (e.g. it would 
be a real mistake to import messenger's skin -- what if the user installed 
navigator only?)...

look in navigator.xul and you'll see it now only imports a skin file from its 
own package, navigator/
verified change in 2000021509 installation
Status: RESOLVED → VERIFIED
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: amasri → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.