Closed Bug 20829 Opened 26 years ago Closed 25 years ago

[Skins] Messengercompose is loading editor's master skin file

Categories

(MailNews Core :: Networking, defect, P3)

Product:
MailNews Core
Component:
Networking
Platform:
x86
Other
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: hyatt, Assigned: bugzilla)

References

Details

(Whiteboard: [PDT-])

The mail compose window is loading editor's master skin. It should not be doing this. Filing a bug so that this can be fixed.
MsGAttachPage.xul is also guilty of this.
Assignee: phil → ducarroz
Reassign to ducarroz, cc hangas
Status: NEW → ASSIGNED
Target Milestone: M13
Target Milestone: M13 → M15
Is there a beta stopper in here? I don't see one, so pushing past B1. Feel free to move it back if I'm mistaken.
Adding [beta], since we will be localizig it, and making a dependency for 12394.
Blocks: 12394
Summary: [Skins] Messengercompose is loading editor's master skin file → [BETA][Skins] Messengercompose is loading editor's master skin file
These are pre-requisites of localizable chrome. Marking them [BETA]. Please fix them by M14 so that we can be ready for localization. To make the chrome localizable, the font name, font size, and UI geometry setting needs to be externalized and move to chrome/[package]/locale/*.css. Adding lyecies, amasri, and tao into CC list. Thanks
Due to Beta indication in Summary, putting beta1 into keyword field.
Keywords: beta1
Since Hyatt has no plan to address the skinnable chrome problems in beta, this bug won't be fixed in beta1, either. L10n engineers had been informed that they might need to localize the *.xul or skin/*.css shall we need to adjust the UI. Place move it to the highest priority post beta 1.
Putting on PDT- radar for beta1. It's on M15 which is next up after beta1 :-)
Whiteboard: [PDT-]
Summary: [BETA][Skins] Messengercompose is loading editor's master skin file → [Skins] Messengercompose is loading editor's master skin file
messengercompose.xul and MsgAttachPage.xul don't load anymore directly the editor skin. However, they load messengercompose skin which load the editor skin. Do you consider that as a fix for this bug?
No that would not be a fix. First, a component's skin should only be loaded by that component. Second, by loading the editor skin, global.css is being loaded twice. This will slow down the window load, not to mention it is evil.
Ok, the reason while we load editor skin if because of the formatting toolbar, without it we loose all the icons. In order to stop loading it, I need the editor team to extract, from editor.css, everything needed by the editorOverlay.xul and put it into a file that the overlay will load itself. Reassign to cmanske.
Assignee: ducarroz → cmanske
Status: ASSIGNED → NEW
Status: NEW → ASSIGNED
Other modules that use editorOverlay.xul (Mail Composer and IM) should not include any CSS files for the editor. editorOverlay.xul now includes EditorToolbar.css, which does not include global.css.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
reassign to myself and reopen it until I fix message compose
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
reasign to myself
Assignee: cmanske → ducarroz
Status: REOPENED → NEW
Accepting
Status: NEW → ASSIGNED
I changed messengercompose.xul as part of the fix.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago → 25 years ago
Resolution: --- → FIXED
I also changed appropriate files in IM.
oh great, thanks
Pratik, pls verify. If the UI doesn't show boxes / outlines around the icons and controls anymore, then we can mark this bug verified.
QA Contact: lchiang → pratikd
Using Build Id: 2000-06-09-08 M17, MAC, NT4, Linux 6.1 Verified: Fixed
Status: RESOLVED → VERIFIED
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.