Closed Bug 208318 Opened 21 years ago Closed 21 years ago

[AxPlugin] Set clip children bit on plugin

Categories

(Core Graveyard :: Embedding: APIs, defect)

x86
Windows XP
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: adamlock, Assigned: adamlock)

References

Details

(Keywords: fixed1.4)

Attachments

(1 file)

Some controls create child windows. The plugin window doesn't set the
WS_CLIPCHILDREN bit so they end up painting improperly.
Attached patch PatchSplinter Review
Simple patch sets WS_CLIPCHILDREN
Comment on attachment 124930 [details] [diff] [review]
Patch

Requesting r/sr on this obvious fix to fix painting problems
Attachment #124930 - Flags: superreview?(alecf)
Attachment #124930 - Flags: review?(dbradley)
Blocks: 190852
Comment on attachment 124930 [details] [diff] [review]
Patch

r=dbradley
Attachment #124930 - Flags: review?(dbradley) → review+
Comment on attachment 124930 [details] [diff] [review]
Patch

sr=alecf
Attachment #124930 - Flags: superreview?(alecf) → superreview+
Comment on attachment 124930 [details] [diff] [review]
Patch

Requesting 1.4 approval on this simple and obvious fix to prevent control
painting issues.
Attachment #124930 - Flags: approval1.4?
Comment on attachment 124930 [details] [diff] [review]
Patch

a=asa (on behalf of drivers) for checkin to the 1.4 branch.
Attachment #124930 - Flags: approval1.4? → approval1.4+
a=adt.  Please check into the branch and add fixed1.4 keyword.
Fix checked into trunk and 1.4 branch
Status: NEW → RESOLVED
Closed: 21 years ago
Keywords: fixed1.4
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: