Missing domstubs.h from Gecko SDK

RESOLVED FIXED

Status

()

RESOLVED FIXED
16 years ago
10 years ago

People

(Reporter: aaronlev, Unassigned)

Tracking

(Depends on: 1 bug, {fixed1.4.1})

Trunk
x86
Windows 2000
fixed1.4.1
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

16 years ago
When I download the SDK from here:
ftp://ftp.mozilla.org/pub/mozilla/releases/mozilla1.4b/gecko-sdk-win32-1.4b.zip
I get no domstubs.h

Now when I try to build a project using the SDK I get a build error

Now I get
nsAccessProxy.cpp
c:\moz\gecko-sdk\dom\include\nsidomeventlistener.h(10) : fatal error C1083:
Cannot open include file: 'domstubs.h': No such file or directory
nsAccessProxyRegistration.cpp
c:\moz\gecko-sdk\dom\include\nsidomeventlistener.h(10) : fatal error C1083:
Cannot open include file: 'domstubs.h': No such file or directory
Error executing cl.exe.
(Reporter)

Comment 1

16 years ago
How am I supposed to use the nsIDOM*.idl stuff without domstubs.h? Or?
(Reporter)

Updated

16 years ago
Depends on: 100112
(Reporter)

Comment 2

16 years ago
The embedding SDK also seems to require nSIDOM3Node.h.

I noticed bug 100112 is about removing the need for domstubs.idl. What's
happening with this?

Comment 3

16 years ago
domstubs was a hack to fix a deficiency in XPConnect that has long been fixed.
Unfortunately, someone added some string-null-checking stuff to it a while back:
http://lxr.mozilla.org/seamonkey/source/dom/public/idl/base/domstubs.idl#43

which is frankly kind of redundant, and doesn't belong in this file in the
slightest. IMO, this file should be killed. some not-so-clever perl hackery
could get rid of those redudnant inline string methods.
(Reporter)

Comment 4

16 years ago
I don't understand how bug 100112 can be minused. Is the embedding SDK supposed
to stand on its own? 

There is also the problem with nsIDOM3Node.h
nsIDOM3Node should not be part of any embedding SDK yet, it's nowhere close to
complete, and should not be used by embedders.
(Reporter)

Comment 6

16 years ago
Johnny, I cannot include nsIDOMNode.h without it.

nsIDOMNode.idl has a line
#include "nsIDOM3Node.idl"
(Reporter)

Comment 7

16 years ago
Created attachment 125294 [details] [diff] [review]
Fix nsIDOM3Node.idl dependency in nsIDOMNode.idl
(Reporter)

Updated

16 years ago
Attachment #125294 - Flags: review?(jst)
Comment on attachment 125294 [details] [diff] [review]
Fix nsIDOM3Node.idl dependency in nsIDOMNode.idl

r+sr=jst
Attachment #125294 - Flags: superreview+
Attachment #125294 - Flags: review?(jst)
Attachment #125294 - Flags: review+
(Reporter)

Comment 9

16 years ago
This is still open because domstubs is still a problem. The patch I checked in
only fixed the nsIDOM3Node problem.

As far as I can tell, the 1.4 SDK will be of limited use without domstubs.h. Or?

Comment 10

16 years ago
jst, can domstubs.h be exported to the SDK for 1.4?  It looks pretty safe to me
assuming that all of the declared interfaces are frozen.  

aaron, if not, can you do the work to rid the tree of this header file?

Fine with me, though all interfaces referenced in that file are not frozen, like
the crypto ones, and nsIDOMWindowInterna, and probably one or two more. But
those are just forward declarations, do we care that they're not frozen?
(Reporter)

Comment 12

16 years ago
Doug, I'd prefer to keep domstubs.h rather than work up a patch to remove this
from the tree.

Do the interfaces really need to be frozen if they're in forward declarations?

Comment 13

16 years ago
no real reason that this can't ship in the sdk.
(Reporter)

Comment 14

16 years ago
Created attachment 126560 [details] [diff] [review]
Add domstubs.idl to SDK
(Reporter)

Updated

16 years ago
Attachment #126560 - Flags: review?(jst)

Comment 15

16 years ago
Comment on attachment 126560 [details] [diff] [review]
Add domstubs.idl to SDK

this is a build change only.  This should to into 1.4 so that this file shows
up in the 1.4 SDK.  Again, it will not change the behavior of any binary -- it
basically just makes another copy of this file in dist/sdk/dom/...
Attachment #126560 - Flags: approval1.4?
Comment on attachment 126560 [details] [diff] [review]
Add domstubs.idl to SDK

r+sr=jst
Attachment #126560 - Flags: superreview+
Attachment #126560 - Flags: review?(jst)
Attachment #126560 - Flags: review+
(Reporter)

Comment 17

16 years ago
checked in
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED

Comment 18

15 years ago
Comment on attachment 126560 [details] [diff] [review]
Add domstubs.idl to SDK

moving approval request forward.
Attachment #126560 - Flags: approval1.4? → approval1.4.x?
(Reporter)

Comment 19

15 years ago
Comment on attachment 125294 [details] [diff] [review]
Fix nsIDOM3Node.idl dependency in nsIDOMNode.idl

This patch is also an important part of the DOM dependency fix for Gecko SDK in
this bug.
Attachment #125294 - Flags: approval1.4.x?
(Reporter)

Comment 20

15 years ago
Comment on attachment 126560 [details] [diff] [review]
Add domstubs.idl to SDK

Asa gave a= via email
Attachment #126560 - Flags: approval1.4.x? → approval1.4.x+
(Reporter)

Comment 21

15 years ago
Second patch checked into 1.4 branch.

Still need to check in first patch if we truly want to fix the dom dependency
problems in the SDK.

Updated

15 years ago
Keywords: fixed1.4.1

Comment 22

15 years ago
Aaron, has this fix been already checked into 1.4 branch?

Comment 23

15 years ago
Comment on attachment 125294 [details] [diff] [review]
Fix nsIDOM3Node.idl dependency in nsIDOMNode.idl

too late for 1.4.1. if you'd like to see this in the next 1.4.x release please
set the approval1.4.2? flag.
Attachment #125294 - Flags: approval1.4.1? → approval1.4.1-

Updated

15 years ago
Blocks: 224532

Updated

10 years ago
Component: DOM: Core → DOM: Core & HTML
QA Contact: desale → general
You need to log in before you can comment on or make changes to this bug.