208464 - From the Start menu select Help & Support and a blank window appears

Status: VERIFIED FIXED

(SeaMonkey :: Installer, defect)

Description

[Ninoschka Baca]

Trunk and branch build 2003-06-05: WinMe

Overview: Select the Help & Support menu item off of the Start menu and it opens
a blank window.

Steps to reproduce:
1. Install the latest build
2. Select Start|Programs|Netscape|Help & Support
3. If the profile manager appears then select a profile

Actual Results: A blank Help window screen appears.

Expected Results: A populated Help window should appear similar to selecting
Help|Help & Support Center from the Navigator window or pressing the F1 key.

Comment 1

[Ninoschka Baca]

Marking nsbeta1 so this bug is fixed for this release.

Comment 2

[Sean Su]

this is the output in the console that I'm getting when I manually type the
following in the url bar:
  chrome://help/content

JavaScript strict warning:
chrome://help/content/help.js line 99: reference to undefined property
window.arguments

JavaScript error:
chrome://help/content/help.js line 99: window.arguments has no properties

Document chrome://help/content/help.xul loaded successfully

Comment 3

[Sean Su]

this might have been regressed by the fix to bug 195888.

cc:ing neil to see if he has any clues on the cause of this.

Comment 4

[[e-mail]]

Do you know what the command line for that item is?

Comment 5

[[e-mail]]

Attachment: Proposed patch

I wrote this patch to work both with -chrome chrome://help/content/ and also
[JS console] openDialog('chrome://help/content','','chrome,all,dialog=no'), and
also tested it to make sure the "Help" button in editor image properties still
works.

Comment 6

[Sean Su]

reassigning to neil since he's got a patch.

Comment 7

[Samir Gehani]

adt: nsbeta1+/adt2

Comment 8

[Sean Su]

Comment on attachment 125078 [details] [diff] [review]
Proposed patch

I get the following error when I enter 'chrome://help/content' manually in the
browser url bar:
  JavaScript error:
 line 0: uncaught exception: [Exception... "Component returned failure code:
0x80004005 (NS_ERROR_FAILURE) [nsIWebNavigation.sessionHistory]"  nsresult:
"0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame ::
chrome://help/content/help.js :: init :: line 118"  data: no]

However, I don't think people will doing this anyways.	I would consider this
as an edge case.

otherwise, the patch looks good.

r=ssu

Comment 9

[(not reading, please use [e-mail] instead)]

ssu, do you want to drive this in to 1.4 and the trunk?

seems worth taking to me.

Comment 10

[Asa Dotzler [:asa]]

Comment on attachment 125078 [details] [diff] [review]
Proposed patch

a=asa (on behalf of drivers) for checkin to the 1.4 branch.

Comment 11

[Sean Su]

patch checked in to both trunk and branch.

Comment 12

[esther]

qa to reporter nbaca

Comment 13

[esther]

Using branch build 20030612 on winxp this is fixed. verified in branch
Note:tested on winxp because I saw the problem with builds before fix.

Comment 14

[Ninoschka Baca]

Trunk build 2003-06-12: Win2k
Verified Fixed.

Comment 15

[Paul Wyskoczka]

Removing fixed1.4 keyword since fix has been verified on the branch by Esther