208588 - [FIX] LINK element with href attribute should match :link

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Mats Palmgren (inactive)]

LINK element with href attribute should match :link

REPEAT BY:
1. load http://www.bath.ac.uk/%7Epy8ieh/internet/projects/mozilla/linktests.html

ACTUAL BEHAVIOUR:
The first list of links at the top are missing.

EXPECTED BEHAVIOUR:
Three list-items that works as links (same as for AREA and A below)

PLATFORM & BUILD:
Mozilla nightly build 2003-06-03-05 trunk Linux

ADDITIONAL INFORMATION:
It worked at the time bug 44396 was verified, 2000-08-25.

Comment 1

[Hixie (not reading bugmail)]

-> style system

Comment 2

[Mats Palmgren (inactive)]

FWIW, bug occurs in Mozilla 1.0.2 too.

Comment 3

[Mats Palmgren (inactive)]

Attachment: Patch rev. 1

It's the following call in nsStyleUtil::IsHTMLLink(...) that returns NULL
for all LINK elements:

    nsCOMPtr<nsILink> link( do_QueryInterface(aContent) );

http://lxr.mozilla.org/mozilla/source/content/html/style/src/nsStyleUtil.cpp#572


The patch adds the nsILink interface to the LINK element.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 125161 [details] [diff] [review]
Patch rev. 1

This was a regression from the changes in revision 1.30 of the file.  r=dbaron

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

->Mats

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in to trunk, 2003-06-08 12:53 -0700.