208781 - Accessible focus events not getting fired for profile manager list items

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Aaron Leventhal]

When I startup with the profile manager, and I arrow in the listbox, no
accessible focus events are getting fired.

Comment 1

[Aaron Leventhal]

Attachment: Use DOMMenuItemActive event -- we don't even want to fire state change events when the list item changes

Comment 2

[Kyle Yuan]

Comment on attachment 125221 [details] [diff] [review]
Use DOMMenuItemActive event -- we don't even want to fire state change events when the list item changes

r=kyle

Comment 3

[Aaron Leventhal]

Comment on attachment 125221 [details] [diff] [review]
Use DOMMenuItemActive event -- we don't even want to fire state change events when the list item changes

Seek sr= from Jag, because of 1 line listbox.xml change

Comment 4

[jag (Peter Annema)]

Comment on attachment 125221 [details] [diff] [review]
Use DOMMenuItemActive event -- we don't even want to fire state change events when the list item changes

>Index: accessible/src/base/nsRootAccessible.cpp
>===================================================================

>     target->RemoveEventListener(NS_LITERAL_STRING("DOMMenuBarInactive"), NS_STATIC_CAST(nsIDOMXULListener*, this), PR_TRUE);
>     target->RemoveEventListener(NS_LITERAL_STRING("RadioStateChange"), NS_STATIC_CAST(nsIDOMXULListener*, this), PR_TRUE);
>-    target->RemoveEventListener(NS_LITERAL_STRING("ListitemStateChange"), NS_STATIC_CAST(nsIDOMXULListener*, this), PR_TRUE);

It looks like all three of the above can/should be removed, they're dupes.

sr=jag

Comment 5

[Aaron Leventhal]

checked in

Comment 6

[Kyle Yuan]

Comment on attachment 125221 [details] [diff] [review]
Use DOMMenuItemActive event -- we don't even want to fire state change events when the list item changes

For making the accessibility feature work better and more stable in 1.4.x, we
need to get this patch in. This fix has been in trunk for a long period. It
won't affect other modules.

Comment 7

[Asa Dotzler [:asa]]

Comment on attachment 125221 [details] [diff] [review]
Use DOMMenuItemActive event -- we don't even want to fire state change events when the list item changes

This is not going to make 1.4.1.  Please re-request aproval after 1.4.1 ships
if you'd like to get this in for 1.4.2. 
Kyle, can you all take this into your tree locally until after 1.4.1 ships
(real soon now) and then work with us to get it landed first thing for 1.4.2?

Comment 8

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1527381