Accessible focus events not getting fired for profile manager list items

RESOLVED FIXED

Status

()

Core
Disability Access APIs
RESOLVED FIXED
15 years ago
15 years ago

People

(Reporter: Aaron Leventhal, Assigned: Aaron Leventhal)

Tracking

({access, sec508})

Trunk
access, sec508
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: in-process-accessibility)

Attachments

(1 attachment)

(Assignee)

Description

15 years ago
When I startup with the profile manager, and I arrow in the listbox, no
accessible focus events are getting fired.
(Assignee)

Updated

15 years ago
OS: AIX → All
(Assignee)

Comment 1

15 years ago
Created attachment 125221 [details] [diff] [review]
Use DOMMenuItemActive event -- we don't even want to fire state change events when the list item changes
(Assignee)

Updated

15 years ago
Attachment #125221 - Flags: review?(kyle.yuan)

Comment 2

15 years ago
Comment on attachment 125221 [details] [diff] [review]
Use DOMMenuItemActive event -- we don't even want to fire state change events when the list item changes

r=kyle
Attachment #125221 - Flags: review?(kyle.yuan) → review+
(Assignee)

Comment 3

15 years ago
Comment on attachment 125221 [details] [diff] [review]
Use DOMMenuItemActive event -- we don't even want to fire state change events when the list item changes

Seek sr= from Jag, because of 1 line listbox.xml change
Attachment #125221 - Flags: superreview?(jaggernaut)

Comment 4

15 years ago
Comment on attachment 125221 [details] [diff] [review]
Use DOMMenuItemActive event -- we don't even want to fire state change events when the list item changes

>Index: accessible/src/base/nsRootAccessible.cpp
>===================================================================

>     target->RemoveEventListener(NS_LITERAL_STRING("DOMMenuBarInactive"), NS_STATIC_CAST(nsIDOMXULListener*, this), PR_TRUE);
>     target->RemoveEventListener(NS_LITERAL_STRING("RadioStateChange"), NS_STATIC_CAST(nsIDOMXULListener*, this), PR_TRUE);
>-    target->RemoveEventListener(NS_LITERAL_STRING("ListitemStateChange"), NS_STATIC_CAST(nsIDOMXULListener*, this), PR_TRUE);

It looks like all three of the above can/should be removed, they're dupes.

sr=jag
Attachment #125221 - Flags: superreview?(jaggernaut) → superreview+
(Assignee)

Comment 5

15 years ago
checked in
Status: NEW → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
(Assignee)

Updated

15 years ago
Whiteboard: in-process-accessibility

Comment 6

15 years ago
Comment on attachment 125221 [details] [diff] [review]
Use DOMMenuItemActive event -- we don't even want to fire state change events when the list item changes

For making the accessibility feature work better and more stable in 1.4.x, we
need to get this patch in. This fix has been in trunk for a long period. It
won't affect other modules.
Attachment #125221 - Flags: approval1.4.x?

Comment 7

15 years ago
Comment on attachment 125221 [details] [diff] [review]
Use DOMMenuItemActive event -- we don't even want to fire state change events when the list item changes

This is not going to make 1.4.1.  Please re-request aproval after 1.4.1 ships
if you'd like to get this in for 1.4.2. 
Kyle, can you all take this into your tree locally until after 1.4.1 ships
(real soon now) and then work with us to get it landed first thing for 1.4.2?
Attachment #125221 - Flags: approval1.4.x? → approval1.4.x-
You need to log in before you can comment on or make changes to this bug.