208907 - Page proxy icon not always disabled when urlbar is blank

Status: RESOLVED WORKSFORME

(SeaMonkey :: UI Design, defect)

Description

[[e-mail]]

Steps to reproduce problem:
1. Open a blank tab
2. Press ESC
3. Switch tabs
4. Switch to the blank tab
Expected result: Disabled icon
Actual result: Enabled icon

Comment 1

[HJ]

Jag, don't you think you should also check location?

http://lxr.mozilla.org/seamonkey/source/xpfe/browser/resources/content/nsBrowserStatusHandler.js#306
-      if (userTypedValue === null)
+      if (location && location != "about:blank" && userTypedValue === null)

This prevents tab switching and new tabs to open with the proxy icon enabled.

Comment 2

[[e-mail]]

Don't check for about:blank, line 285 already does that.

Comment 3

[HJ]

This line:
285     if (!getWebNavigation().canGoBack && location == "about:blank")
checks for "about:blank" for new tabs only! It doesn't work for tab switching.

Comment 4

[HJ]

Preliminary step: add a simple bookmark with "about:blank"

Steps to reproduce:
1) open a new tab
2) load some page, until the back button is activated
3) load that bookmark

Result: there ya go, one heck of an proxy icon enabled, is that what you want?

note: this has nothing to do with tab switching, that's another bug I'm working
on (:

Comment 5

[HJ]

Attachment: proposed patch for this bug

Comment 6

[[e-mail]]

No, it is not what I want. Loading about:blank after an existing page should
display an enabled icon, but a new blank tab should display a disabled icon.

Comment 7

[HJ]

Well, if that's what you want:

306       if (userTypedValue === null) {
306       if (location && userTypedValue === null) {

Comment 8

[Philip Chee]

WFM Mozilla/5.0 (Windows; U; Windows NT 5.1; rv:1.9.1b4pre) Gecko/20090309 SeaMonkey/2.0b1pre