208922 - Convert nsIAccessNode into an interface for internal accessibility clients

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Aaron Leventhal]

Internal XPCOM-based accessibilty clients need nsIAccessNode to give them some
of the same capabilities as ISimpleDOMNode does for external COM-based clients.

In addition, the methods Shutdown() and Init() need to be moved to a private
interface.

Comment 1

[Aaron Leventhal]

Attachment: Add methods to nsIAccessNode, split off nsPIAccessNode, implement new methods

Comment 2

[Kyle Yuan]

Aaron, what is "XPCOM-based accessibilty clients"? Is that a tool like DOM 
inspector?

Comment 3

[Aaron Leventhal]

Kyle, it's an XPCOM DLL that gets loaded in process at startup, and uses 
nsIAccessible and our other XPCOM accessibility interfaces directly, as well as 
be able to use the nsIDOM and any other frozen interfaces in the embedding SDK. 
It will get acccessibility events through nsIObserver. In the end it can send 
text to the speech driver directly, or communicate with the screen reader or 
other assistive technology in whatever way the vendor decides.

It will be a little bit like nsAccessProxy, but that is old code, and I´m 
updating it now.

Comment 4

[Kyle Yuan]

Comment on attachment 125310 [details] [diff] [review]
Add methods to nsIAccessNode, split off nsPIAccessNode, implement new methods

r=kyle

Comment 5

[Alec Flett]

Comment on attachment 125310 [details] [diff] [review]
Add methods to nsIAccessNode, split off nsPIAccessNode, implement new methods

I like the cleanup, but where is nsPIAccessNode? Always remember to cvs diff
-N!

is this part of your patch:
-  if (role == EVENT_OBJECT_REORDER) {
-    // Probably need to do this somewhere else so simple dom nodes get
shutdown
-    nsCOMPtr<nsIAccessNode> accessNode(do_QueryInterface(aAccessible));
-    accessNode->Shutdown();
-  }

sr=alecf but I want to see nsPIAccessNode.idl in a seperate patch/attachment

Comment 6

[Aaron Leventhal]

Attachment: Missing nsPIAccessNode.idl part of patch

Comment 7

[Aaron Leventhal]

is this part of your patch:
-  if (role == EVENT_OBJECT_REORDER) {
-    // Probably need to do this somewhere else so simple dom nodes get
shutdown
-    nsCOMPtr<nsIAccessNode> accessNode(do_QueryInterface(aAccessible));
-    accessNode->Shutdown();
-  }

That code was supposed to be removed a while ago, but it somehow didn't.
We take care of shutting down accessnodes based on mutation events in
nsDocAccessible.cpp now.

Comment 8

[Alec Flett]

sounds like grounds for a different bug - in case there is a regression its
going to be a lot easier to track if the bug in the checkin comments matches the
actual bug that you're trying to fix.

Comment 9

[Aaron Leventhal]

checked in

Comment 10

[timeless]

this hosed cafe (gtk2) on seamonkey-ports, people talked about it for a while
(wondering why no one cared). at some point someone asked for help and
eventually w/ his help and w/ bz's i made enough changes to fix it.

Comment 11

[Kyle Yuan]

Comment on attachment 125310 [details] [diff] [review]
Add methods to nsIAccessNode, split off nsPIAccessNode, implement new methods

For making the accessibility feature work better and more stable in 1.4.x, we
need to get this patch in. This fix has been in trunk for a long period. It
won't affect other modules.

Comment 12

[Asa Dotzler [:asa]]

Comment on attachment 125310 [details] [diff] [review]
Add methods to nsIAccessNode, split off nsPIAccessNode, implement new methods

This is not going to make 1.4.1.  Please re-request aproval after 1.4.1 ships
if you'd like to get this in for 1.4.2. 
Kyle, can you all take this into your tree locally until after 1.4.1 ships
(real soon now) and then work with us to get it landed first thing for 1.4.2?