209093 - nsITextToSubURI should use ACString, not string, throughout

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[Brendan Eich [:brendan]]

http://lxr.mozilla.org/mozilla/source/intl/uconv/idl/nsITextToSubURI.idl#51
http://lxr.mozilla.org/mozilla/source/intl/uconv/idl/nsITextToSubURI.idl#52

Also, please fix Unescape's spelling -- don't InterCap within a word.

/be

Comment 1

[Brendan Eich [:brendan]]

Doing so would save some (almost certainly trivial in terms of runtime)
nsCAutoString constructions in callers who have non-flat strings to convert.

It dawned on me that the "Un" applies to (EscapeAndConvert), hence the odd
InterCaps.  But does Convert really add anything to either method's name?  I
think it's just noise.  Escape and Unescape would be shorter and sweeter.

/be

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

it does now - https://searchfox.org/mozilla-central/source/intl/uconv/nsITextToSubURI.idl