209117 - clicking on links in mail message uses front most, instead of "last" browser window

Status: RESOLVED EXPIRED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[(not reading, please use [e-mail] instead)]

jst points out that clicking on links in mail message uses front most, instead
of "last" browser window.

my fix for bug #199360 sounds like the cause.

from that bug, I added:

Index: xpfe/communicator/resources/content/contentAreaUtils.js
===================================================================
RCS file: /cvsroot/mozilla/xpfe/communicator/resources/content/contentAreaUtils.js,v
retrieving revision 1.74
diff -u -w -r1.74 contentAreaUtils.js
--- xpfe/communicator/resources/content/contentAreaUtils.js	10 Jan 2003
04:08:04 -0000	1.74
+++ xpfe/communicator/resources/content/contentAreaUtils.js	11 Apr 2003 20:47:48
-0000
@@ -102,6 +102,18 @@
   window.openDialog(getBrowserURL(), "_blank", "chrome,all,dialog=no", url,
charsetArg, referrer);
 }
 
+function openTopBrowserWith(url)
+{
+  var windowMediator =
Components.classes["@mozilla.org/appshell/window-mediator;1"].getService(Components.interfaces.nsIWindowMediator);
+  var browserWin = windowMediator.getMostRecentWindow("navigator:browser");
+
+  // if there's an existing browser window, open this url in one
+  if (browserWin)
+    browserWin.getBrowser().loadURI(url); // Just do a normal load.
+  else
+    window.openDialog(getBrowserURL(), "_blank", "chrome,all,dialog=no", url,
null, null);
+}

to restore the old behaviour, I might try to cache the last used window, and if
I can't find it, I'll use the topmost.

Comment 1

[(not reading, please use [e-mail] instead)]

jst thinks this is a blocker, so adding 1.4?

accepting.

Comment 2

[Asa Dotzler [:asa]]

I don't this is something we should hold 1.4 over but we could certainly
consider a low-risk fix for either 1.4 or 1.4.1

Comment 3

[(not reading, please use [e-mail] instead)]

I'll investigate, for 1.5alpha, and if I can get a low risk fix, seek approval
for 1.4 (or 1.4.1)

when jst says "jump!", I say "how high?"

Comment 4

[(not reading, please use [e-mail] instead)]

no fix yet, and too late for 1.4.

sorry jst, still on my todo list.

Comment 5

[(not reading, please use [e-mail] instead)]

I'm a loser, sorry jst.  moving out until I have cycles.

Comment 6

[Robert Kaiser]

MASS-CHANGE:
This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state.

If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way.
If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar).
If no action happens within the next few months, we move this bug report to an EXPIRED state.

Query tag for this change: mass-UNCONFIRM-20090614

Comment 7

[Robert Kaiser]

MASS-CHANGE:
This bug report is registered in the SeaMonkey product, but still has no comment since the inception of the SeaMonkey project 5 years ago.

Because of this, we're resolving the bug as EXPIRED.

If you still can reproduce the bug on SeaMonkey 2 or otherwise think it's still valid, please REOPEN it and if it is a platform or toolkit issue, move it to the according component.

Query tag for this change: EXPIRED-20100420