209532 - [Patch] Prefs to override user agent app name and app version

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect)

Description

[Marco Pesenti Gritti]

These would make life for embedders a lot easier.
To implement an UA string like suggested in
http://www.mozilla.org/build/revised-user-agent-strings.html
at the moment we need to build the user agent string ourself and to use the
override pref.

Comment 1

[Marco Pesenti Gritti]

Attachment: add the two prefs

Comment 2

[Darin Fisher]

Comment on attachment 125740 [details] [diff] [review]
add the two prefs

r+sr=darin (ok)

Comment 3

[[e-mail]]

Fix checked in.

Comment 4

[Robert Kaiser]

This hosed my UA string completely in my current cvs build.

My current UA is "/ (X11; U; Linux i686; de-AT; rv:1.6a) Gecko/20031007" !!!

about:config reports general.useragent.contentlocale, general.useragent.locale
and  general.useragent.security set but no other general.useragent.* prefs to be
set to anything.

I guess Mozilla now somehow gets empty strings for appName and appVersion and
uses them.

Java made Mozilla not even start by the following error message:
INTERNAL ERROR on Browser End: Expected a version > 5! Version = 0

This also happens because of this damaged UA string.

Comment 5

[[e-mail]]

Attachment: Possible fix for empty prefs

Comment 6

[Matthias Versen [:Matti]]

*** Bug 221807 has been marked as a duplicate of this bug. ***

Comment 7

[Matthias Versen [:Matti]]

reopening

Comment 8

[Stefan Borggraefe]

Comment on attachment 133008 [details] [diff] [review]
Possible fix for empty prefs

I've tested this patch and it fixes the regression for me.

Comment 9

[Mike Connor [:mconnor]]

*** Bug 221795 has been marked as a duplicate of this bug. ***

Comment 10

[Robert Kaiser]

The fix seems to work, I have a Mozilla/5.0 user agent again, and Java likes me
again ;-)

Comment 11

[Darin Fisher]

Comment on attachment 133008 [details] [diff] [review]
Possible fix for empty prefs

yes, of course!  we actually depend on the other UA string pref values
existing.  otherwise, things just aren't happy.  i should have remembered!

r+sr=darin

Comment 12

[[e-mail]]

Supplementary fix checked in.