209706 - Scrollbars can draw when their container widgets are hidden

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Simon Fraser [no longer active]]

In an embedding app that uses carbon events, it's possible for scrollbars to
draw when they should be hidden. The problem is that control drawing happens via
carbon events and the control hierarhcy, bypassing Gecko, and we never hide the
native controls when we hide their parent widgets.

Comment 1

[Simon Fraser [no longer active]]

Attachment: Patch to call ContainerHierarchyIsVisible() from the draw event handler

P

Comment 2

[Simon Fraser [no longer active]]

Comment on attachment 125864 [details] [diff] [review]
Patch to call ContainerHierarchyIsVisible() from the draw event handler

Note that diff was -w, and I'm detabbing the MacControlDrawHandler() function.
nsWindow.h has a mess of spaces/tabs in it.

Comment 3

[Conrad Carlen (not reading bugmail)]

Comment on attachment 125864 [details] [diff] [review]
Patch to call ContainerHierarchyIsVisible() from the draw event handler

Is it worth it to ensure that the native control is hidden when its widget is
hidden so that the event handler doesn't fire when it shouldn't in the first
place?

But, since the container visibility check looks fast, and this is a good safety
net, r=ccarlen

Comment 4

[Simon Fraser [no longer active]]

To do that we'd have to trawl through child widgets ever time an ancestor widget
gets hidden, looking for native controls to hide. Since hiding and showing is
less common that drawing, that might be more efficient, but is more work.

Comment 5

[L. H.]

Dup of bug 187435?

Comment 6

[José Jeria]

Is this patch still valid? As said in comment 5, this is the same issue as bug
187435

Comment 7

[Uri Bernstein]

-> Widget: Mac (based on patch)

Requesting blocking1.8b3, since this has a simple, reviewed, patch.

Comment 8

[Uri Bernstein]

It turnes out that the patch is for Mozilla 1.2 branch code which never got
applied to the trunk (see bug 205873).
Removing blocking request and apologizing for the spam.

Comment 9

[Simon Fraser [no longer active]]

Note to self: see if this should go in.

Comment 10

[Håkan Waara]

Would this (possibly outdated?) patch fix bug 187435 ?

Comment 11

[Simon Fraser [no longer active]]

I think Mark has made changes that make this patch obsolete. Reassigning to him to do what he wants with it.

Comment 12

[Samuel Sidler (old account; do not CC)]

I bet this was fixed with our cocoa scrollbar rewrite...

Comment 13

[Josh Aas]

This is fixed with cocoa widgets and HITheme scrollbar drawing.