Closed Bug 209748 Opened 21 years ago Closed 18 years ago

Marking e-mail as Junk moves selection to next e-mail, even if marked <> selected (privacy)

Categories

(MailNews Core :: Backend, defect)

Product:
MailNews Core
Component:
Backend
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: Peter, Assigned: Bienvenu)

References

Details

(Keywords: fixed1.8.1)

Attachments

(1 file)

proposed fix
1.83 KB, patch
mscott
: superreview+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (Windows; U; WinNT4.0; en-US; rv:1.4b; MultiZilla v1.4.0.4A) Gecko/20030615
Build Identifier: Mozilla/5.0 (Windows; U; WinNT4.0; en-US; rv:1.4b; MultiZilla v1.4.0.4A) Gecko/20030615

Marking e-mail as Junk moves selection to next e-mail, even if marked <>
selected (privacy)

Reproducible: Always

Steps to Reproduce:
1. in inbox, select an e-mail (above an unmarked junkmail)
2. mark another mail as junk (not the one below the selection)

Actual Results:  
Maring causes selection to move to next e-mail, which (in this case) could be
another junk mail. This could cause the mail to "load" and potentially verify
the user's e-mail address to the junk mailer.

Expected Results:  
The selection should stay where it was (on the non-junk mail).
I don't see this when I have selected a message above a junk mail and then mark
the junk mail as junk.  I see this when I have selected a message below a junk
mail and then mark the junk mail as junk.  All the messages below the junk mail
move up / the selection moves down and so it opens the message below the message
I just marked junk (often another junk mail).

It would be nice if no message were selected after you mark a message as junk,
just stay on the same message, or just show a blank window or the mail start page.
Compare bug 211495.

Does the same happen for Delete?
Unlikely; Delete has an ugly hack to determine that you're deleting from the
context menu and in that case preventing the adjustment of the selection.
I see this, too. I think the difference in "above or below" has to do with where
the subject line is positioned inside the viewing box.  I know it sounds weird,
and I wish I could test to verify THAT right now, but I can't.

If the message you are marking is toward the top of the scrolled list of
messages, the focus will move one direction, if it is low in the scrolled list,
it will move the other direction.

Hope this helps.
similar behavior:
- have "move incoming messages determined to be junk to <some folder>" activated 
  in junk mail controls
- select a message in the list
- mark a message above the selected message as junk. as expected, it gets moved to
  my junk folder.
- however, the selection also moves away from the selected message to the next one
  in the list. expected behavior: do not change message selection as the deletion
  of the junk message had nothing to do with the selected message.
*** Bug 229826 has been marked as a duplicate of this bug. ***
*** Bug 224329 has been marked as a duplicate of this bug. ***
I would love to see some forward momentum on this, please?  Is there anything I
can do to help?
I was surprized to find that this bug was not fixed in the latest update.  here
is what I posted to the newsgroups...

I thought this had been fixed long ago, but perhaps it is because I use
different settings than most?

Would someone please verify I am not loosing my mind on this?  Please change
priority to higher since it is not being fixed?

Duplicating the problem:
Mozilla Thunderbird 0.5 (20040207)

Sort by= Date ascending*** (This means that the NEWEST of incoming mail is
located at the bottom of my top window [I do have a preview pane.])
General Windows Configuration = (leftmost [3-window])
Composition = Start my reply above the quote
Junk mail controls:
    Move incoming messages to JUNK on Local folder
    When manually marked, move to Junk folder

Problem:
Get new mail.
Newest is marked as unread and at the bottom of the top window, in a list of
subjects/Junk/Sender/Date
Select and read the bottom two emails so that they now appear "un-bolded" to
show as read.
Select the second, read message, from the bottom. (Focus is now there.)
Click the JUNK icon on the next-up NEW email.

That it moved to the junk folder and FOCUS moves (sometimes) down to the
top-most, read message.
Now mark the next unread message as JUNK.
Now the FOCUS jumps down to the BOTTOM read message!

Expectations:
First let me say that SOMETIMES, if I have not-contiguous selections of read and
unread, the FOCUS seems to change directional movement and it goes UP!!
But since I have not figured out hoe, exactly, to duplicate that behavior, I
will pose this setting.

I suppose my desire in this situation would be for the FOCUS to go BETWEEN the
last READ message and the NEXT MESSAGE UP.
If not that then I would like for the FOCUS to disappear. (Lately, to overcome
this issue, I have NOT allowed a message to be selected before going through and
marking my JUNK selections.

If I allow the FOCUS to move as I am complaining about, it will go downward
until it reaches the bottom of my emails. Since I first read SOME emails, but
not all, this movement downward over email lines can inadvertently mark messages
I have skipped over to become listed as READ.


Perhaps others here can lend a hand and help me to describe the problem better? 


*** Bug 238421 has been marked as a duplicate of this bug. ***
I see the same behaviour.

I have chosen "When I manually mark messages as Junk: Delete them" in the Junk
Mail Controls dialogue box. If I click on the junk column of the thread pane to
mark a message as junk while reading another message, the selection bar moves to
the next message. It should stay where it was.
As the original defect filer pointed out, this is potentially a security issue 
since it makes you open mails that you did not want to explicitly open.
*** Bug 230044 has been marked as a duplicate of this bug. ***
*** Bug 229676 has been marked as a duplicate of this bug. ***
*** Bug 217200 has been marked as a duplicate of this bug. ***
*** Bug 235322 has been marked as a duplicate of this bug. ***
*** Bug 226873 has been marked as a duplicate of this bug. ***
It seems to me that the behavior descrbied in this bug has stopped -- 
TB 0.8 and Moz 1.8a5-1011, Windows 2000. (But see bug 264973.)

Peter Lairo, do you also see that this now works properly?
I spoke a bit too soon.  The selection does not move if the junked mail is 
below the selection; the selection does move if the junked mail is above the 
selection.  So the problem has reversed.
Argh.  Retesting with  version 0.8+ (20041028)  I'm now seeing the original 
problem -- selection *below* the junked message moving, but not the selection 
*above*.

xref bug 266066, a recent regression that's somewhat related.
*** Bug 267994 has been marked as a duplicate of this bug. ***
Moving to front end because I'm tired of searching for this one and not finding 
it.
Component: Filters → Mail Window Front End
Product: Browser → Seamonkey
Assignee: sspitzer → mail
This is still broken in 1.0.5.
Marking a message as junk that is above current selection causes selection to
move to the message after the current selection. (bad!)

Marking a message as junk that is below current selection does not move current
selection. (good!)
Could we change this bug's Product to "Core"? (I'm more interested in
Thunderbird than in the Suite)
Assignee: mail → nobody
Severity: major → normal
Component: MailNews: Main Mail Window → MailNews: Backend
OS: Windows NT → All
Product: Mozilla Application Suite → Core
QA Contact: laurel
Hardware: PC → All
I think this bug should be Severity:MAJOR since it can cause a junk e-mail to
"load" and potentially verify the user's e-mail address to the junk mailer.
(In reply to comment #24)
> I think this bug should be Severity:MAJOR since it can cause a junk e-mail to
> "load" and potentially verify the user's e-mail address to the junk mailer.

That *could* happen for the case where the 'current' message (not the one that 
just got marked as junk) happened to be directly above an unidentified junk 
message that's been adequately spoofed as from someone in your address book.
Otherwise, TB does an excellent job of not loading stuff from the web into a 
message, except when it should.

And in fact, the potential for that problem has been slightly worsened of late, 
due to the fix for bug 280153 (see bug 304676).

And I simply don't care; it's not a major bug.  The workaround for this unlikely 
case is to turn off block-whitelisting on the address book; then if you need to 
see the pictures Aunt Tilly sent you, you can click the Show Images button when 
you view the message.
The same kind of thing can happen if you:
 1. automatically send reciept requests.
 2. mark messages read when you land on them

I have missed several important emails because of this bug.  My boss wants it
fixed, too!

I have just observed this behavior in TB 1.5b2 (20051006), OS X. This is a new behavior in my experience. This was definitely not how it worked in 1.0.x, going back as many versions as I can remember, on the Mac or on Windows. 

Relevant configuration options: 

* "Remember last message" is off
* Spam is moved to the Junk folder on Local Folders

Steps to repeat: 

1. Select a folder. No message will be focused.
2. Identify a spam message and click the indicator in the "spam" column to mark the message as spam. 
3. Message is marked as read (new behavior), and moved to the Junk folder; and the message immediately following that message is focused (it is also marked as read).

Alternate steps to repeat; 

1. Select a folder. No message will be focused.
2. Identify a block of spam messages and select them using shift-click or command-click (Mac), and click the "Junk" button to mark the message as spam. 
3. All selected messages are marked as read (new behavior) and moved to the junk folder, and the message immediately following that selected message block is focused (it is also marked as read).


(In reply to comment #27)
> I have just observed this behavior in TB 1.5b2 (20051006), OS X. This is a new
> behavior in my experience. 

The behavior that this bug describes is not new; this bug was opened in 2003.
Bug 220933 and bug 306026 are the bugs relevant to the marking-as-junk-
marks-read change.  At least this bug is arguably related; bug 304676, which 
you also spammed, is completely unrelated.
*** Bug 323772 has been marked as a duplicate of this bug. ***
*** Bug 323794 has been marked as a duplicate of this bug. ***
*** Bug 322980 has been marked as a duplicate of this bug. ***
*** Bug 324188 has been marked as a duplicate of this bug. ***
*** Bug 325771 has been marked as a duplicate of this bug. ***
(In reply to comment #28)
> (In reply to comment #27)
> > I have just observed this behavior in TB 1.5b2 (20051006), OS X. This is a new
> > behavior in my experience. 
> 
> The behavior that this bug describes is not new; this bug was opened in 2003.

I have to confirm comment #27: I have never seen this behaviour before TB 1.5. Like I told in bug 322980, I notice this with IMAP account with "Mark it as deleted" setting on, if it matters. I fear that the logic change of bug 220933 causes these problems...
This is a new bug for me on upgrade to TB 1.5.  It wasn't happening before.  I have noticed that even if I don't have a message selected (highlighted) and I mark a message for junk.  The message gets moved to my junk folder and then the message that moved into the spot that was just emptied by the junk mail gets selected as the active message and previewed.  This seems to me to be a big security problem if my mail browser is opening messages without my express consent.  

In previous versions if I had highligted a message and then marked it as junk then it would automatically select the message that moved into it's spot.  As much as that was an issue I was able to work around it.  The above problem I cannot work around because it is automatically selecting messages that could possibly be junk and there is no way to select all my junk messages without either opening one of them or selecting all my messages and then having to go back through and unselct those that I want to keep.  
This is NOT a new bug. I have been watching this bug for years! It was present in Mozilla and its still present in TB...
This bug is not new, but it *is* now more visible, due to a different fix -- 
as mentioned months ago in comment 25.  Read and understand the whole bug 
before spamming it.
> This bug is not new, but it *is* now more visible, due to a different fix

The problem I tried to report in bug 322980 is exactly what you describe in 304676 comment 5, and as you say, it was introduced in 1.5. Which of the bugs tracks that problem?
Blocks: 324188
Attached patch proposed fix — — Splinter Review 
if the message being junked is not selected, don't do anything to the selection.
Assignee: nobody → bienvenu
Status: NEW → ASSIGNED
Attachment #213280 - Flags: superreview?(mscott)
Attachment #213280 - Flags: superreview?(mscott) → superreview+
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
V with TB 3.0a1-0303, Win2K.
Thanks very much, David!
Status: RESOLVED → VERIFIED
*** Bug 283918 has been marked as a duplicate of this bug. ***
*** Bug 264973 has been marked as a duplicate of this bug. ***
*** Bug 336245 has been marked as a duplicate of this bug. ***
*** Bug 349313 has been marked as a duplicate of this bug. ***
*** Bug 321846 has been marked as a duplicate of this bug. ***
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: