Crash in accessibility when doc is destroyed

RESOLVED FIXED

Status

()

RESOLVED FIXED
16 years ago
15 years ago

People

(Reporter: aaronlev, Assigned: aaronlev)

Tracking

({access})

Trunk
access
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: in-process-accessibility)

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

16 years ago
This is a regresion from bug 202080, where we introduced the new thashtable.

When the doc is destroyed, we end up trying to access a null hash table.
(Assignee)

Comment 1

16 years ago
oops should be assigned to me
Assignee: kyle.yuan → aaronl
(Assignee)

Comment 2

16 years ago
Created attachment 126076 [details] [diff] [review]
Fixes thashtable destruction, uses comptrs instead of weak refs

I need to test to make sure this still doesn't leak
(Assignee)

Comment 3

16 years ago
Created attachment 126110 [details] [diff] [review]
Remove unneccessary null setters in InvalidateChildren(), make mParent an nsCOMPtr, fix hash table destruction
Attachment #126076 - Attachment is obsolete: true
(Assignee)

Updated

16 years ago
Attachment #126110 - Flags: review?(kyle.yuan)

Comment 4

16 years ago
Comment on attachment 126110 [details] [diff] [review]
Remove unneccessary null setters in InvalidateChildren(), make mParent an nsCOMPtr, fix hash table destruction

r=kyle
Attachment #126110 - Flags: review?(kyle.yuan) → review+
(Assignee)

Comment 5

16 years ago
Comment on attachment 126110 [details] [diff] [review]
Remove unneccessary null setters in InvalidateChildren(), make mParent an nsCOMPtr, fix hash table destruction

I tested, changing mParent to an nsCOMPtr doesn't cause any leaks.
Attachment #126110 - Flags: superreview?(alecf)

Comment 6

16 years ago
Comment on attachment 126110 [details] [diff] [review]
Remove unneccessary null setters in InvalidateChildren(), make mParent an nsCOMPtr, fix hash table destruction

sr=alecf
Attachment #126110 - Flags: superreview?(alecf) → superreview+
(Assignee)

Comment 7

16 years ago
checked in
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
(Assignee)

Updated

16 years ago
Whiteboard: in-process-accessibility

Comment 8

15 years ago
Comment on attachment 126110 [details] [diff] [review]
Remove unneccessary null setters in InvalidateChildren(), make mParent an nsCOMPtr, fix hash table destruction

For making the accessibility feature work better and more stable in 1.4.x, we
need to get this patch in. This fix has been in trunk for a long period. It
won't affect other modules.
Attachment #126110 - Flags: approval1.4.x?

Comment 9

15 years ago
Comment on attachment 126110 [details] [diff] [review]
Remove unneccessary null setters in InvalidateChildren(), make mParent an nsCOMPtr, fix hash table destruction

This is not going to make 1.4.1.  Please re-request aproval after 1.4.1 ships
if you'd like to get this in for 1.4.2. 
Kyle, can you all take this into your tree locally until after 1.4.1 ships
(real soon now) and then work with us to get it landed first thing for 1.4.2?
Attachment #126110 - Flags: approval1.4.x? → approval1.4.x-
You need to log in before you can comment on or make changes to this bug.