Leaks caused by new in process accessibility events

RESOLVED FIXED

Status

()

RESOLVED FIXED
16 years ago
15 years ago

People

(Reporter: aaronlev, Assigned: aaronlev)

Tracking

({access})

Trunk
access
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

16 years ago
The nsIAccessibleEvent objects created by nsDocAccessible::FireToolkitEvent()
are leaking.

My mistake -- it shouldn't act like a getter, it should release the newly
created object when finished.
(Assignee)

Comment 1

16 years ago
Created attachment 126111 [details] [diff] [review]
Use nsCOMptr
(Assignee)

Updated

16 years ago
Attachment #126111 - Flags: review?(kyle.yuan)

Comment 2

16 years ago
Comment on attachment 126111 [details] [diff] [review]
Use nsCOMptr

r=kyle
Attachment #126111 - Flags: review?(kyle.yuan) → review+
(Assignee)

Comment 3

16 years ago
Comment on attachment 126111 [details] [diff] [review]
Use nsCOMptr

Short patch.
Attachment #126111 - Flags: superreview?(alecf)

Comment 4

16 years ago
Comment on attachment 126111 [details] [diff] [review]
Use nsCOMptr

sr=alecf
Attachment #126111 - Flags: superreview?(alecf) → superreview+
(Assignee)

Comment 5

16 years ago
checked in
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED

Comment 6

15 years ago
Comment on attachment 126111 [details] [diff] [review]
Use nsCOMptr

This patch is very simple and won't affect  any other modules.
Attachment #126111 - Flags: approval1.4.x?

Comment 7

15 years ago
Comment on attachment 126111 [details] [diff] [review]
Use nsCOMptr

This is not going to make 1.4.1.  Please re-request aproval after 1.4.1 ships
if you'd like to get this in for 1.4.2. 
Kyle, can you all take this into your tree locally until after 1.4.1 ships
(real soon now) and then work with us to get it landed first thing for 1.4.2?
Attachment #126111 - Flags: approval1.4.x? → approval1.4.x-
You need to log in before you can comment on or make changes to this bug.