Closed
Bug 210141
Opened 22 years ago
Closed 22 years ago
JAVASCRIPT_GLOBAL_PROPERTY_CATEGORY stuff shouldn't be readonly
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla1.5beta
People
(Reporter: axel, Assigned: jst)
References
Details
(Whiteboard: [HAVE FIX])
Attachments
(1 file)
|
2.06 KB,
patch
|
axel
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
nsDOMClassInfo.cpp should :JS_DefineUCProperty global properties registered
with the component manager as JSPROP_ENUMERATE, not
JSPROP_ENUMERATE | JSPROP_READONLY.
This way, js scripts can still use the variable name. The current code throws a
redeclaration of const
error on var foo;
jst has a patch for that.
|
Assignee | |
Comment 1•22 years ago
|
||
|
|
Assignee | |
Updated•22 years ago
|
Attachment #126328 -
Flags: superreview?(peterv)
Attachment #126328 -
Flags: review?(axel)
|
|
Assignee | |
Updated•22 years ago
|
Status: NEW → ASSIGNED
Whiteboard: [HAVE FIX]
Target Milestone: --- → mozilla1.5beta
|
Reporter | |
Comment 2•22 years ago
|
||
Comment on attachment 126328 [details] [diff] [review]
Proposed fix.
r=me.
(btw, peterv said he'd be mostly out of reach for the next two weeks.)
Attachment #126328 -
Flags: review?(axel) → review+
|
|
Assignee | |
Comment 3•22 years ago
|
||
Comment on attachment 126328 [details] [diff] [review]
Proposed fix.
Oh, right... Boris, could you sr?
Attachment #126328 -
Flags: superreview?(peterv) → superreview?(bzbarsky)
|
||
Updated•22 years ago
|
Attachment #126328 -
Flags: superreview?(bzbarsky) → superreview+
|
|
Assignee | |
Comment 4•22 years ago
|
||
Fixed.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•