Closed
Bug 210162
Opened 22 years ago
Closed 22 years ago
Fix up comments, argument names of atom getters in nsIAtom.idl
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
People
(Reporter: jag+mozilla, Assigned: jag+mozilla)
Details
Attachments
(1 file)
|
4.00 KB,
patch
|
bzbarsky
:
review+
dbaron
:
superreview+
|
Details | Diff | Splinter Review |
|
Assignee | |
Comment 1•22 years ago
|
||
|
|
Assignee | |
Updated•22 years ago
|
Attachment #126161 -
Flags: superreview?(dbaron)
Attachment #126161 -
Flags: review?(alecf)
|
||
Comment 2•22 years ago
|
||
Comment on attachment 126161 [details] [diff] [review]
patch
r=bzbarsky, but I'd very much like it if we removed the NS_NewAtom functions
altogether, since they are somewhat leak-prone (if people assign from them into
nsCOMPtr). Follow-up bug for that, perhaps?
Attachment #126161 -
Flags: review?(alecf) → review+
Attachment #126161 -
Flags: superreview?(dbaron) → superreview+
(I wonder if we should also change the do_ names to NS_ names.)
|
|
Assignee | |
Comment 4•22 years ago
|
||
Hmmm, I prefer the do_ names over the NS_ names.
|
|
Assignee | |
Comment 5•22 years ago
|
||
Checked in.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•