210216 - remove useless nsChromeRegistry::mUIDataSource

Status: RESOLVED INVALID

(Core Graveyard :: RDF, defect)

Description

[Benjamin Smedberg]

I've been cleaning unused functions and members in the tree, and found
nsChromeRegistry::mUIDataSource which seems unused, except for the constructor
that creates it. Proposing removal, patch forthcoming.

Comment 1

[Benjamin Smedberg]

Attachment: remove nsChromeRegistry::mUIDataSource

Comment 2

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Comment on attachment 126198 [details] [diff] [review]
remove nsChromeRegistry::mUIDataSource

sr=shaver, and this is simple enough that we don't need to bug rjc for
additional review.  Thanks.

Comment 3

[Robert John Churchill]

Comment on attachment 126198 [details] [diff] [review]
remove nsChromeRegistry::mUIDataSource

r=rjc
I appreciate the sentiment.  :)

Comment 4

[Benjamin Smedberg]

checked in. As it turns out, that removes the last reference to 
http://lxr.mozilla.org/seamonkey/source/rdf/chrome/src/nsChromeUIDataSource.h
and cpp

Can I get approval to remove these from the makefile and then from CVS?

Comment 5

[Benjamin Smedberg]

Attachment: Remove UIDatasource altogether

Little patch, so I can request review

Comment 6

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Comment on attachment 126362 [details] [diff] [review]
Remove UIDatasource altogether

My favourite kind of patch; r/sr=shaver.

Comment 7

[Brian Ryner (not reading)]

Whoa there.  This is definitely not unused.  Removing the creation of this data
source caused regression bugs 210377 and 210437.  I'm backing out the previous
checkin.

Comment 8

[David Hyatt]

Yeah, this data source is used to do both the themes UI (in Mozilla and
Firebird) and the extensions UI (in Firebird).  

Lesson: it is dangerous to make assumptions based solely off LXR crawling.  :)

Comment 9

[Benjamin Smedberg]

Well, then... [embarrased grin] can I get a quick explanation as to how
mUIDataSource gets used? Is it accessed through a global RDF graph of some sort?

Comment 10

[Jan Varga [:janv]]

Search for "rdf:chrome"