21024 - nsEditor::SetAttribute() needs undo transaction

Status: VERIFIED WORKSFORME

(Core :: DOM: Editor, defect, P3)

Description

[Charles Manske]

This method creates a transaction and thus should be undoable.
An example of its use is when inserting a table row when there is colspan >1.
I'll supply a test file shortly.

Comment 1

[Charles Manske]

Attachment: A Table with colspan > 1 for testing table editing

Comment 2

[Charles Manske]

To test the bug:
1. Open attached test file.
2. Place caret in cell with "10".
3. Execute Table | Insert | Row
You should see a new row of cells, and the cell with "6" had its COLSPAN
increased by 1.
4. Execute File | Undo
The insert cells are removed, but the colspan in cell with "6" is not restored.

Comment 3

[rubydoo123]

setting to M13

Comment 4

[buster]

the test case seems to work already, and on inspection ChangeAttributeTxn (which
does all the work for nsEditor::SetAttribute()) looks correct.  Reassigning to
Charley for more info about what is needed.

Comment 5

[Charles Manske]

This seems to be working, but there are some table display problems I want to
investigate before closing this.

Comment 6

[Charles Manske]

I don't think we (editor team) did anything to fix this, but it does seem to
work now. Because of bug 22246, inserting a row or column in a location that
changes COLSPAN or ROWSPAN won't redraw the table correctly. Thus validiting
this is indirect:
2. Execute the menu command "Debug | Test Table Layout". Note that the 2nd
cell in second row has a ROWSPAN = 3.
1. Follow the directions to insert a new row in the attached test file. Either
"Row above" or "Row below" can be used.
2. Execute "Test Table Layout" again and now the ROWSPAN is 4.
3. Execute Undo, then Test Table Layout again and the ROWSPAN is changed back
to 3.

Comment 7

[sujay]

verified in 12/3 build.