210321 - Enhancements to OS/2 Drag and Drop code

Status: RESOLVED FIXED

(Core :: DOM: Copy & Paste and Drag & Drop, enhancement)

Description

[Rich Walsh]

User-Agent:       Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.5a) Gecko/20030619
Build Identifier: Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.5a) Gecko/20030619

The attached patch provides "baseline" enhancements to drag & drop features on
OS/2.  Additional enhancements will be offered if these are accepted.

-- Drag selected text to the Desktop to create a file; its title is derived from
the text.
-- Drag & drop URLs of any length;  the current restriction of (roughly) 255
characters is eliminated.
-- URL object titles that are just a copy of the URL are reformatted as
"hostname/filename".

Note:  d&d text may not always produce expected results due to previously
reported bugs in nsContentAreaDragDrop (see bug #174842, comment #2 for a
description).  I am about to submit a patch to fix them;  however, the
enhancements offered here are not directly dependent on that patch being accepted.

Reproducible: Always

Steps to Reproduce:
1.n/a
2.
3.

Actual Results:  
n/a

Expected Results:  
n/a

Comment 1

[Rich Walsh]

Attachment: diff showing changes to nsDragService & nsWindow

Comment 2

[Rich Walsh]

Attachment: revised portions of nsDragService & nsWindow after applying patch

You're probably used to reading garbled diffs, but I'm including this copy of
the final product just in case...

Comment 3

[Mike Kaply [:mkaply]]

Over to Javier

Comment 4

[Mike Kaply [:mkaply]]

Fixes checked in